From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: "Christian König" <christian.koenig@amd.com>,
"Dave Airlie" <airlied@gmail.com>,
"Ben Skeggs" <skeggsb@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v10 03/11] drm/ttm: Add a generic TTM memcpy move for page-based iomem
Date: Mon, 30 Aug 2021 09:53:53 +0200 [thread overview]
Message-ID: <b87231ff-ced5-a9ca-af22-d6e84e9f7263@linux.intel.com> (raw)
In-Reply-To: <1c8ee7b0-97ef-0c04-8e92-ec6bdc56bd40@amd.com>
Hi!
On 8/30/21 8:16 AM, Christian König wrote:
> Am 30.08.21 um 03:54 schrieb Dave Airlie:
>> I've just been talking with Ben about nouveau having some issues since
>> this path,
>>
>> ttm_resource can be subclassed by drivers, and the code below that
>> copies ttm_resources around pretty much seems to destroy that.
>>
>>
>>> + struct ttm_resource *src_mem = &bo->mem;
>>> + struct ttm_resource_manager *src_man =
>>> + ttm_manager_type(bdev, src_mem->mem_type);
>>> + struct ttm_resource src_copy = *src_mem;
>> This here ^^
>
> Mhm, that's most likely a rebase/merge conflict between my change to
> subclass ttm_resource which came in through the drm-misc-next tree and
> Thomas change here.
>
> Thomas can you take a look?
>
> Thanks,
> Christian.
>
Posted a patch.
Ben, it would be great if you could help give it a try to verify that it
works. I'll give it a try on vmwgfx later today if I can get it running.
Looks like VMware mesa is broken on Fedora..
/Thomas
next prev parent reply other threads:[~2021-08-30 7:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 8:38 [PATCH v10 00/11] Move LMEM (VRAM) management over to TTM Thomas Hellström
2021-06-02 8:38 ` [PATCH v10 01/11] drm/i915/ttm Initialize the ttm device and memory managers Thomas Hellström
2021-06-02 8:38 ` [PATCH v10 02/11] drm/i915/ttm: Embed a ttm buffer object in the i915 gem object Thomas Hellström
2021-06-02 8:38 ` [PATCH v10 03/11] drm/ttm: Add a generic TTM memcpy move for page-based iomem Thomas Hellström
2021-08-30 1:54 ` [Intel-gfx] " Dave Airlie
2021-08-30 6:16 ` Christian König
2021-08-30 7:08 ` Thomas Hellström
2021-08-30 7:53 ` Thomas Hellström [this message]
2021-06-02 8:38 ` [PATCH v10 04/11] drm: Add a prefetching memcpy_from_wc Thomas Hellström
2021-06-02 8:38 ` [PATCH v10 05/11] drm/ttm: Use drm_memcpy_from_wc for TTM bo moves Thomas Hellström
2021-06-02 8:38 ` [PATCH v10 06/11] drm/ttm: Document and optimize ttm_bo_pipeline_gutting() Thomas Hellström
2021-06-02 8:38 ` [PATCH v10 07/11] drm/ttm, drm/amdgpu: Allow the driver some control over swapping Thomas Hellström
2021-06-02 8:38 ` [PATCH v10 08/11] drm/i915/ttm: Introduce a TTM i915 gem object backend Thomas Hellström
2021-06-02 8:38 ` [PATCH v10 09/11] drm/i915/lmem: Verify checks for lmem residency Thomas Hellström
2021-06-02 8:38 ` [PATCH v10 10/11] drm/vma: Add a driver_private member to vma_node Thomas Hellström
2021-06-02 8:38 ` [PATCH v10 11/11] drm/i915: Use ttm mmap handling for ttm bo's Thomas Hellström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b87231ff-ced5-a9ca-af22-d6e84e9f7263@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=airlied@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=skeggsb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).