From: Jyri Sarha <jsarha@ti.com>
To: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Cc: "Valkeinen, Tomi" <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: DRM driver and runtime suspend-resume handling?
Date: Mon, 13 Jan 2020 13:03:11 +0200 [thread overview]
Message-ID: <df769d2e-5fea-403f-2d04-b3239f89256f@ti.com> (raw)
Hi,
While working with CRTC color related properties (gamma and CTM for
instance) and making them persistent over suspend-resume cycle it
occurred to me if I am just wasting resources by storing the property
values in the driver and restoring them in dev_pm_ops runtime_resume()..
Wouldn't it work if I would just:
1. Add a flag in the driver to indicate that the context may have been
lost since the previous atomic commit and set in runtime_resume().
2. And write the color properties to HW if the context lost flag is set
even if the drm_crtc_state color_mgmt_changed is false.
The color property values are there despite the color_mgmt_changed ==
false, aren't they?
Best regards,
Jyri
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2020-01-13 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 11:03 Jyri Sarha [this message]
2020-01-14 4:29 ` DRM driver and runtime suspend-resume handling? Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df769d2e-5fea-403f-2d04-b3239f89256f@ti.com \
--to=jsarha@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).