From: "Michel Dänzer" <michel@daenzer.net>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: clang-built-linux@googlegroups.com,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Cast remain to unsigned long in eb_relocate_vma
Date: Fri, 14 Feb 2020 16:36:12 +0100 [thread overview]
Message-ID: <ff302c03-d012-a80d-b818-b7feababb86b@daenzer.net> (raw)
In-Reply-To: <87o8u1wfqs.fsf@intel.com>
On 2020-02-14 12:49 p.m., Jani Nikula wrote:
> On Fri, 14 Feb 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> Quoting Jani Nikula (2020-02-14 06:36:15)
>>> On Thu, 13 Feb 2020, Nathan Chancellor <natechancellor@gmail.com> wrote:
>>>> A recent commit in clang added -Wtautological-compare to -Wall, which is
>>>> enabled for i915 after -Wtautological-compare is disabled for the rest
>>>> of the kernel so we see the following warning on x86_64:
>>>>
>>>> ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1433:22: warning:
>>>> result of comparison of constant 576460752303423487 with expression of
>>>> type 'unsigned int' is always false
>>>> [-Wtautological-constant-out-of-range-compare]
>>>> if (unlikely(remain > N_RELOC(ULONG_MAX)))
>>>> ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
>>>> ../include/linux/compiler.h:78:42: note: expanded from macro 'unlikely'
>>>> # define unlikely(x) __builtin_expect(!!(x), 0)
>>>> ^
>>>> 1 warning generated.
>>>>
>>>> It is not wrong in the case where ULONG_MAX > UINT_MAX but it does not
>>>> account for the case where this file is built for 32-bit x86, where
>>>> ULONG_MAX == UINT_MAX and this check is still relevant.
>>>>
>>>> Cast remain to unsigned long, which keeps the generated code the same
>>>> (verified with clang-11 on x86_64 and GCC 9.2.0 on x86 and x86_64) and
>>>> the warning is silenced so we can catch more potential issues in the
>>>> future.
>>>>
>>>> Link: https://github.com/ClangBuiltLinux/linux/issues/778
>>>> Suggested-by: Michel Dänzer <michel@daenzer.net>
>>>> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>>>
>>> Works for me as a workaround,
>>
>> But the whole point was that the compiler could see that it was
>> impossible and not emit the code. Doesn't this break that?
>
> It seems that goal and the warning are fundamentally incompatible.
Not really:
if (sizeof(remain) >= sizeof(unsigned long) &&
unlikely(remain > N_RELOC(ULONG_MAX)))
return -EINVAL;
In contrast to the cast, this doesn't generate any machine code on 64-bit:
https://godbolt.org/z/GmUE4S
but still generates the same code on 32-bit:
https://godbolt.org/z/hAoz8L
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-14 15:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 5:47 [PATCH] drm/i915: Cast remain to unsigned long in eb_relocate_vma Nathan Chancellor
2020-02-14 6:36 ` Jani Nikula
2020-02-14 8:32 ` Chris Wilson
2020-02-14 11:49 ` Jani Nikula
2020-02-14 15:36 ` Michel Dänzer [this message]
2020-03-16 21:41 ` Nick Desaulniers
2020-03-26 20:11 ` Nathan Chancellor
2020-03-26 22:15 ` Jani Nikula
2020-02-14 13:46 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff302c03-d012-a80d-b818-b7feababb86b@daenzer.net \
--to=michel@daenzer.net \
--cc=chris@chris-wilson.co.uk \
--cc=clang-built-linux@googlegroups.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).