From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A42C433E3 for ; Sun, 26 Jul 2020 17:53:26 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 678812065F for ; Sun, 26 Jul 2020 17:53:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 678812065F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 492A58523B; Sun, 26 Jul 2020 17:53:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1KXtq8vTDfwc; Sun, 26 Jul 2020 17:53:22 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 47B5586493; Sun, 26 Jul 2020 17:53:22 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 5BDDA1BF42D for ; Sun, 26 Jul 2020 17:53:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 4C1F720243 for ; Sun, 26 Jul 2020 17:53:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W3AaRPQZxKcY for ; Sun, 26 Jul 2020 17:53:20 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from smtprelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by silver.osuosl.org (Postfix) with ESMTPS id 1F9C520108 for ; Sun, 26 Jul 2020 17:53:20 +0000 (UTC) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave05.hostedemail.com (Postfix) with ESMTP id 628921828AC8C for ; Sun, 26 Jul 2020 17:15:37 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id F15A5182CED5B; Sun, 26 Jul 2020 17:15:34 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: sound58_281484c26f5a X-Filterd-Recvd-Size: 1982 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Sun, 26 Jul 2020 17:15:33 +0000 (UTC) Message-ID: <1177f80aa848a294f65e305729304b76d1e5ee98.camel@perches.com> Subject: Re: [PATCH v3 3/4] staging: rtl8723bs: include: Further clean up function declarations From: Joe Perches To: Greg KH , Aditya Jain Date: Sun, 26 Jul 2020 10:15:32 -0700 In-Reply-To: <20200726150244.GD452766@kroah.com> References: <20200726141831.2662-1-aditya.jainadityajain.jain@gmail.com> <20200726142013.2891-1-aditya.jainadityajain.jain@gmail.com> <20200726142013.2891-3-aditya.jainadityajain.jain@gmail.com> <20200726150244.GD452766@kroah.com> User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sun, 2020-07-26 at 17:02 +0200, Greg KH wrote: > On Sun, Jul 26, 2020 at 07:50:12PM +0530, Aditya Jain wrote: > > Cleaning up messy multiline function declarations in hal_phy_cfg.h [] > > diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h [] > > -void > > -PHY_SetSwChnlBWMode8723B( > > -struct adapter *Adapter, > > -u8 channel, > > -enum CHANNEL_WIDTH Bandwidth, > > -u8 Offset40, > > -u8 Offset80 > > +void PHY_SetBWMode8723B(struct adapter *Adapter, > > + enum CHANNEL_WIDTH Bandwidth, /* 20M or 40M */ > > + unsigned char Offset /* Upper, Lower, or Don't care */ > > Those comments should go at the top of the function declaration, in > kernel doc format. Not every external function needs kernel-doc. This is a realtek staging driver that likely it will never be moved out of staging. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel