From: Joe Perches <joe@perches.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: devel@driverdev.osuosl.org, Kirk Reiser <kirk@reisers.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org,
MugilRaj <dmugil2000@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Chris Brannon <chris@the-brannons.com>
Subject: Re: [PATCH] taging: speakup: remove volatile
Date: Fri, 22 May 2020 10:22:03 -0700 [thread overview]
Message-ID: <162676bb69044efadd31daa9ea49fc6fb9664297.camel@perches.com> (raw)
In-Reply-To: <20200522171312.s2ciifuxozwav2ym@function>
On Fri, 2020-05-22 at 19:13 +0200, Samuel Thibault wrote:
> Joe Perches, le ven. 22 mai 2020 09:36:05 -0700, a ecrit:
> > On Fri, 2020-05-22 at 13:34 +0300, Dan Carpenter wrote:
> > > On Fri, May 22, 2020 at 02:46:28PM +0530, MugilRaj wrote:
> > > > fix checkpatch.pl warning, which is Use of volatile is usually wrong: see
> > > > Documentation/process/volatile-considered-harmful.rst
> > > > Signed-off-by: MugilRaj <dmugil2000@gmail.com>
> > >
> > > Please put a blank before the Signed-off-by line.
> > >
> > > Probably there should be a space between your first and last name. It's
> > > supposed to your legal name like for signing a legal document so use
> > > whatever is appropriate legal documents in your country.
> > >
> > > Also the Documentation/process/volatile-considered-harmful.rst explains
> > > that people often use "volatile" when they should be using locking for
> > > synchronization. That seems to be the case here. So the correct fix is
> > > to add locking. That's a little bit complicated to do and requires
> > > testing.
> > >
> > > If we apply this patch, then we have silenced the warning so now someone
> > > will have to look for the bug. But if we leave it as-is, then everyone
> > > will know that the code is buggy. So let's leave it as-is until we are
> > > able to fix the bug.
> > >
> > > It's always better to have easy to find bugs, than hidden bugs.
> >
> > And better still to comment known opportunities to
> > improve the code so the next time someone tries to
> > remove this volatile, there's a comment right there
> > showing what's necessary instead.
>
> Actually I don't think adding the suggestion is a good thing if it's
> only a "rule-of-thumb-replace-volatile-with-lock".
>
> Actually possibly volatile might not even be needed because there could
> be already a lock protecting this.
>
> Put another way: I don't think putting any hint here would help, on the
> contrary, somebody has to really look at what protection is needed,
> without getting influenced by rules-of-thumb.
checkpatch newbies/robots will submit this change again otherwise.
Comment wording can always be improved.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-05-22 17:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 9:16 [PATCH] taging: speakup: remove volatile MugilRaj
2020-05-22 9:21 ` Samuel Thibault
2020-05-22 9:37 ` Greg Kroah-Hartman
2020-05-22 10:34 ` Dan Carpenter
2020-05-22 16:36 ` Joe Perches
2020-05-22 17:13 ` Samuel Thibault
2020-05-22 17:22 ` Joe Perches [this message]
2020-05-22 17:25 ` Samuel Thibault
2020-05-22 17:50 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162676bb69044efadd31daa9ea49fc6fb9664297.camel@perches.com \
--to=joe@perches.com \
--cc=chris@the-brannons.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmugil2000@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).