From: Joe Perches <joe@perches.com>
To: Matthew Hanzelik <mrhanzelik@gmail.com>,
jerome.pouiller@silabs.com, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Staging: wfx: Fix style issues with hif_rx.c
Date: Sun, 29 Dec 2019 14:51:58 -0800 [thread overview]
Message-ID: <1ec873d6df7de91c972fa356eb33d65437a3e67b.camel@perches.com> (raw)
In-Reply-To: <20191229223142.5pxmmu7sfwdtcn7d@mandalore.localdomain>
On Sun, 2019-12-29 at 17:31 -0500, Matthew Hanzelik wrote:
> Fix the 80 line limit warning on line 79 of hif_rx.c.
>
> Also fixes the missing blank line warning on line 305 of hif_rx.c after
> the declaration of size_t len.
[]
> diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c
[]
> @@ -76,7 +76,8 @@ static int hif_multi_tx_confirm(struct wfx_dev *wdev, struct hif_msg *hif,
> void *buf)
> {
> struct hif_cnf_multi_transmit *body = buf;
> - struct hif_cnf_tx *buf_loc = (struct hif_cnf_tx *) &body->tx_conf_payload;
> + struct hif_cnf_tx *buf_loc =
> + (struct hif_cnf_tx *) &body->tx_conf_payload;
Just get rid of the cast instead
struct hif_cnf_tx *buf_loc = body->tx_conf_payload;
should work fine.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-12-30 3:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 22:31 [PATCH v3] Staging: wfx: Fix style issues with hif_rx.c Matthew Hanzelik
2019-12-29 22:51 ` Joe Perches [this message]
2019-12-30 11:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ec873d6df7de91c972fa356eb33d65437a3e67b.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jerome.pouiller@silabs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mrhanzelik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).