driverdev-devel.linuxdriverproject.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Lior Pugatch <buzz5800@gmail.com>
Cc: driverdev-devel@linuxdriverproject.org, willy@meta-x.org
Subject: Re: [PATCH] Fix coding style issues.
Date: Wed, 5 Aug 2015 13:38:37 -0700	[thread overview]
Message-ID: <20150805203837.GA16746@kroah.com> (raw)
In-Reply-To: <1438805993-12287-1-git-send-email-buzz5800@gmail.com>

On Wed, Aug 05, 2015 at 11:19:53PM +0300, Lior Pugatch wrote:
> This patch fixes checkpatch.pl warnings,
> related to comments.
> 
> Signed-off-by: Lior Pugatch <buzz5800@gmail.com>
> ---
>  drivers/staging/panel/panel.c | 38 +++++++++++++++++++++++++-------------
>  1 file changed, 25 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> index 3e9ee7e..6b96369 100644
> --- a/drivers/staging/panel/panel.c
> +++ b/drivers/staging/panel/panel.c
> @@ -785,6 +785,7 @@ static void long_sleep(int ms)
>   * send a serial byte to the LCD panel. The caller is responsible for locking
>   * if needed.
>   */
> +

Why is this line added?

And please fix up your subject to say what part of the kernel you are
changing and be more specific, something like:
	staging: panel: fix comment...

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2015-08-05 20:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 20:19 [PATCH] Fix coding style issues Lior Pugatch
2015-08-05 20:38 ` Greg KH [this message]
2020-07-24 20:25 Anant Thazhemadam
2020-07-25  5:49 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150805203837.GA16746@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=buzz5800@gmail.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=willy@meta-x.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).