From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: devel@driverdev.osuosl.org,
Valentin Vidic <vvidic@valentin-vidic.from.hr>,
Valdis Kletnieks <valdis.kletnieks@vt.edu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: exfat: cleanup braces for if/else statements
Date: Tue, 3 Sep 2019 20:19:46 +0200 [thread overview]
Message-ID: <20190903181946.GA14349@kroah.com> (raw)
In-Reply-To: <20190903173249.GL1131@ZenIV.linux.org.uk>
On Tue, Sep 03, 2019 at 06:32:49PM +0100, Al Viro wrote:
> On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote:
> > + } else if (uni == 0xFFFF) {
> > skip = TRUE;
>
> While we are at it, could you get rid of that 'TRUE' macro?
> Or added
>
> #define THE_TRUTH_AND_THATS_CUTTIN_ME_OWN_THROAT true
>
> if you want to properly emphasize it...
No, we don't :)
I cleaned up a bunch of those, there are a lot more still left, it is a
mess...
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-09-03 18:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 16:47 [PATCH] staging: exfat: cleanup braces for if/else statements Valentin Vidic
2019-09-03 17:32 ` Al Viro
2019-09-03 18:12 ` Valentin Vidić
2019-09-04 9:38 ` David Laight
2019-09-04 17:05 ` Valentin Vidić
2019-09-03 18:19 ` Greg Kroah-Hartman [this message]
2019-09-03 18:55 ` [PATCH] staging: exfat: drop local TRUE/FALSE defines Valentin Vidic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903181946.GA14349@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=vvidic@valentin-vidic.from.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).