From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Valentin Vidic <vvidic@valentin-vidic.from.hr>
Cc: devel@driverdev.osuosl.org,
Valdis Kletnieks <valdis.kletnieks@vt.edu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] staging: exfat: drop unused field access_time_ms
Date: Sun, 8 Sep 2019 17:41:40 +0100 [thread overview]
Message-ID: <20190908164140.GB8362@kroah.com> (raw)
In-Reply-To: <20190908161015.26000-2-vvidic@valentin-vidic.from.hr>
On Sun, Sep 08, 2019 at 04:10:14PM +0000, Valentin Vidic wrote:
> Not used in the exfat-fuse implementation and spec defines
> this position should hold the value for CreateUtcOffset.
Then why not just put CreateUtcOffset in here instaed of deleting it?
I would much rather the fields match the spec in the structures for lots
of good reasons, instead of having loads of "reserved[]" variables.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-09-08 16:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 16:10 [PATCH v2 1/3] staging: exfat: drop duplicate date_time_t struct Valentin Vidic
2019-09-08 16:10 ` [PATCH v2 2/3] staging: exfat: drop unused field access_time_ms Valentin Vidic
2019-09-08 16:41 ` Greg Kroah-Hartman [this message]
2019-09-09 0:19 ` Valdis Klētnieks
2019-09-09 6:14 ` Valentin Vidić
2019-09-08 16:10 ` [PATCH v2 3/3] staging: exfat: add millisecond support Valentin Vidic
2019-09-08 16:40 ` Greg Kroah-Hartman
2019-09-08 16:51 ` Valentin Vidić
2019-09-08 16:45 ` [PATCH v2 1/3] staging: exfat: drop duplicate date_time_t struct Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190908164140.GB8362@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
--cc=vvidic@valentin-vidic.from.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).