From: Rohit Sarkar <rohitsarkar5398@gmail.com>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: devel@driverdev.osuosl.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org,
"Tobias Büttner" <tobias.buettner@fau.de>,
"Eric Anholt" <eric@anholt.net>,
linux-rpi-kernel@lists.infradead.org,
"Dominic Braun" <inf.braun@fau.de>
Subject: Re: [PATCH] staging: vhciq_core: replace snprintf with scnprintf
Date: Wed, 11 Sep 2019 19:55:43 +0530 [thread overview]
Message-ID: <20190911142543.GA9873@SARKAR> (raw)
In-Reply-To: <7bf3c74d-e690-1ef1-dd74-ac98667e42ef@i2se.com>
On Wed, Sep 11, 2019 at 04:17:25PM +0200, Stefan Wahren wrote:
> Hi Rohit,
>
> On 11.09.19 15:51, Rohit Sarkar wrote:
> > When the number of bytes to be printed exceeds the limit snprintf
> > returns the number of bytes that would have been printed (if there was
> > no truncation). This might cause issues, hence use scnprintf which
> > returns the actual number of bytes printed to buffer always
> >
> > Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
> thanks for your patch. Did you test your change on the Raspberry Pi?
Hey Stefan,
No I haven't done so as I thought this is a generic change?
Will that be necessary?
I am relatively new to kernel development
Thanks,
Rohit
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-09-11 14:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 13:51 [PATCH] staging: vhciq_core: replace snprintf with scnprintf Rohit Sarkar
2019-09-11 14:17 ` Stefan Wahren
2019-09-11 14:25 ` Rohit Sarkar [this message]
2019-09-11 14:46 ` Dan Carpenter
2019-09-11 15:03 ` Rohit Sarkar
2019-09-11 17:24 ` Dan Carpenter
2019-09-11 17:38 ` Rohit Sarkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911142543.GA9873@SARKAR \
--to=rohitsarkar5398@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=inf.braun@fau.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=tobias.buettner@fau.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).