driverdev-devel.linuxdriverproject.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jesse Barton <jessebarton95@gmail.com>
Cc: devel@driverdev.osuosl.org, valdis.kletnieks@vt.edu,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Staging: exfat: exfat_super.c: fixed camelcase coding style issue
Date: Sun, 29 Sep 2019 16:57:58 +0200	[thread overview]
Message-ID: <20190929145758.GA2017443@kroah.com> (raw)
In-Reply-To: <20190929145057.37752-1-jessebarton95@gmail.com>

On Sun, Sep 29, 2019 at 09:50:57AM -0500, Jesse Barton wrote:
> Changed function names:
> ffsUmountVol to ffs_umount_vol
> ffsMountVol to ffs_mount_vol
> ffsSyncVol to ffs_sync_vol
> 
> 

That says _what_ you did, but not _why_ you are doing this.

And is this really the best name for these functions?  Why the ffs_*
prefix?

Also, you didn't include the maintainer again, and you didn't thread
your emails using 'git send-email' :(

And finally, you sent a new version of the patch, but did not "version"
it, saying what changed from the previous version.  The documentation
says how to do this, so you might want to re-read that.

Can you please fix this all up and resend the series as "v3"?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

      reply	other threads:[~2019-09-30 14:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-29 14:50 [PATCH 1/3] Staging: exfat: exfat_super.c: fixed camelcase coding style issue Jesse Barton
2019-09-29 14:57 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190929145758.GA2017443@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=jessebarton95@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).