From: Xin Ji <xji@analogixsemi.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel@ffwll.ch>,
Sheng Pan <span@analogixsemi.com>
Subject: Re: [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver
Date: Fri, 11 Oct 2019 02:08:50 +0000 [thread overview]
Message-ID: <20191011020838.GA24665@xin-VirtualBox> (raw)
In-Reply-To: <20191010095617.GL13286@kadam>
Hi Dan Carpenter,
This is a bug, I'll fix it right now.
The coding is much nicer than before, thanks for your comments,
it is very helpful for me.
Thanks,
Xin
On Thu, Oct 10, 2019 at 12:56:17PM +0300, Dan Carpenter wrote:
> On Thu, Oct 10, 2019 at 12:53:15PM +0300, Dan Carpenter wrote:
> > This code is *so* much nicer than before. I hope you feel good about
> > the changes. It makes me happy to look at this code now.
> >
> > On Thu, Oct 10, 2019 at 09:34:19AM +0000, Xin Ji wrote:
> > > +static int edid_read(struct anx7625_data *ctx,
> > > + u8 offset, u8 *pblock_buf)
> > > +{
> > > + int ret, cnt;
> > > + struct device *dev = &ctx->client->dev;
> > > +
> > > + for (cnt = 0; cnt < EDID_TRY_CNT; cnt++) {
> ^^^^^
>
> > > + sp_tx_aux_wr(ctx, offset);
> > > + /* set I2C read com 0x01 mot = 0 and read 16 bytes */
> > > + ret = sp_tx_aux_rd(ctx, 0xf1);
> > > +
> > > + if (ret) {
> > > + sp_tx_rst_aux(ctx);
> > > + DRM_DEV_DEBUG_DRIVER(dev, "edid read failed, reset!\n");
> > > + cnt++;
> ^^^^^
>
> I mean that it's incremented twice, yeah?
>
> regards,
> dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-10-11 2:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 9:31 [PATCH v2 0/2] Add initial support for slimport anx7625 Xin Ji
2019-10-10 9:32 ` [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding Xin Ji
2019-10-10 9:34 ` [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver Xin Ji
2019-10-10 9:53 ` Dan Carpenter
2019-10-10 9:56 ` Dan Carpenter
2019-10-11 2:08 ` Xin Ji [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-11 2:20 [PATCH v2 0/2] Add initial support for slimport anx7625 Xin Ji
2019-10-11 2:23 ` [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver Xin Ji
2019-10-14 8:20 ` kbuild test robot
2019-10-15 9:19 ` Dan Carpenter
2019-10-09 9:26 [PATCH v2 0/2] Add initial support for slimport anx7625 Xin Ji
2019-10-09 9:28 ` [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver Xin Ji
2019-10-09 11:30 ` Dan Carpenter
2019-10-09 13:06 ` Dan Carpenter
2019-10-10 3:19 ` Xin Ji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011020838.GA24665@xin-VirtualBox \
--to=xji@analogixsemi.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=span@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).