From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: GAURAV PATHAK <gauravpathak129@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
abbotti@mev.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.
Date: Sun, 24 May 2020 15:58:20 +0200 [thread overview]
Message-ID: <20200524135820.snuv3bffhctwndme@ltop.local> (raw)
In-Reply-To: <20200524124919.GA6889@xebrium.com>
On Sun, May 24, 2020 at 06:19:22PM +0530, GAURAV PATHAK wrote:
> Thanks a lot for your reply.
> I am trying to run sparse on drivers/staging directory,
> but I am not getting any useful warnings.
> Steps that I did:
>
> - Referred https://www.kernel.org/doc/man-pages/linux-next.html to get
> linux-next latest tag next-20200522.
> - After that executed following commands:
> - make mrproper; make clean; make distclean
> - make defconfig
> - make menuconfig (Enabled all Staging Drivers with M)
> - make modules_prepare
> - make C=1 M=drivers/staging (Also tried individual directories
> inside staging directory e.g. make C=1 M=drivers/staging/comedi/drivers)
>
> I am not getting any warning, I have attached the output in text format.
>
> Any pointers for finding warning using sparse in drivers/staging
> directory will be helpful. I really appretiate your guidance in this
> regard.
Well it seems that most staging drivers have no sparse warnings at all.
I only see somes in the following staging drivers:
drivers/staging/isdn/
drivers/staging/kpc2000/
drivers/staging/uwb/
drivers/staging/vc04_services/
drivers/staging/wfx/
drivers/staging/wusbcore/
Your commands seems to be good but I would advice you to use 'C=2'
instead of 'C=1' in order for sparse to effectively run on each
input file even when the corresponding .o file already exists.
The simplest to use is:
- make allmodconfig
- make -j8 drivers/staging/
This will just compile all the files without running sparse.
So all warnings will be from the compiler.
The you can run:
- make C=2 drivers/staging/
which will only run sparse (and will thus be much faster).
Best regards,
-- Luc
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-05-24 13:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 11:36 [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c Gaurav Pathak
2020-05-24 12:10 ` Luc Van Oostenryck
2020-05-24 12:49 ` GAURAV PATHAK
2020-05-24 13:58 ` Luc Van Oostenryck [this message]
2020-05-24 13:32 ` GAURAV PATHAK
2020-05-24 14:08 ` Luc Van Oostenryck
2020-05-26 14:13 ` Dan Carpenter
2020-05-26 14:54 ` GAURAV PATHAK
2020-05-26 15:09 ` Dan Carpenter
2020-05-26 15:50 ` [PATCH v2] Staging: comedi: dt2814: remove unused assignments gaurav
2020-05-26 18:21 ` Dan Carpenter
2020-05-26 18:51 ` [PATCH v3] " Gaurav Pathak
2020-05-26 20:24 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200524135820.snuv3bffhctwndme@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gauravpathak129@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).