driverdev-devel.linuxdriverproject.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Igor Ribeiro Barbosa Duarte <igor.ribeiro.duarte@gmail.com>
Cc: devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: wlan-ng: Fix number of characters warning style.
Date: Tue, 26 May 2020 07:59:32 +0200	[thread overview]
Message-ID: <20200526055932.GB2576013@kroah.com> (raw)
In-Reply-To: <20200525221025.GA27612@igor-Aspire-F5-573G>

On Mon, May 25, 2020 at 07:10:25PM -0300, Igor Ribeiro Barbosa Duarte wrote:
> Fix checkpatch error "WARNING: line over 80 characters" at cfg80211.c:451
> 
> Signed-off-by: Igor Ribeiro Barbosa Duarte <igor.ribeiro.duarte@gmail.com>
> ---
>  drivers/staging/wlan-ng/cfg80211.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index fac38c8..a911bcd 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -447,9 +447,10 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev,
>  	/* Set the channel */
>  	if (channel) {
>  		chan = ieee80211_frequency_to_channel(channel->center_freq);
> -		result = prism2_domibset_uint32(wlandev,
> -						DIDMIB_DOT11PHY_DSSSTABLE_CURRENTCHANNEL,
> -						chan);
> +		result = prism2_domibset_uint32
> +			 (wlandev,
> +			  DIDMIB_DOT11PHY_DSSSTABLE_CURRENTCHANNEL,
> +			  chan);

The original really is easier to read and understand, don't you think
so?

Checkpatch is a hint, it doesn't always have to be followed exactly.
Perhaps that crazy #define could be shortened, or use a more
conventional name?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2020-05-26  5:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25 22:10 [PATCH] staging: wlan-ng: Fix number of characters warning style Igor Ribeiro Barbosa Duarte
2020-05-26  5:59 ` Greg KH [this message]
2020-05-26 15:27   ` Igor Ribeiro Barbosa Duarte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200526055932.GB2576013@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=igor.ribeiro.duarte@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).