driverdev-devel.linuxdriverproject.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Darshan D V <darshandv10@gmail.com>
Cc: devel@driverdev.osuosl.org, contact@christina-quast.de,
	yuehaibing@huawei.com, ardb@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8192e: Fixed a coding style error
Date: Sun, 19 Jul 2020 13:05:38 +0200	[thread overview]
Message-ID: <20200719110538.GB266150@kroah.com> (raw)
In-Reply-To: <20200719105557.12605-1-darshandv10@gmail.com>

On Sun, Jul 19, 2020 at 04:25:56PM +0530, Darshan D V wrote:
>     rtllib_crypt_ccmp.c: Fixed the error - space required before the
>     open parenthesis '(' on line #281.

What does this mean for a changelog text?

And why is it indented?

Did you read the section in the submitting patches document about how to
write a changelog text?  Perhaps you might want to re-read that :)

> Signed-off-by: Darshan D V <darshandv10@gmail.com>

Is this how you sign legal documents?  If so, great, but I have to ask.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

      parent reply	other threads:[~2020-07-19 11:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17 15:04 [PATCH] staging: rtl8192e: Fixed the space and indentation coding styles Darshan D V
2020-07-19  9:22 ` Greg KH
2020-07-19 10:55   ` [PATCH 1/2] staging: rtl8192e: Fixed a coding style error Darshan D V
2020-07-19 10:55     ` [PATCH 2/2] staging: rtl8192e: Fixed a coding style warning Darshan D V
2020-07-19 11:05       ` Greg KH
2020-07-19 11:05     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200719110538.GB266150@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ardb@kernel.org \
    --cc=contact@christina-quast.de \
    --cc=darshandv10@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).