From: Greg KH <gregkh@linuxfoundation.org>
To: Rahul Gottipati <rahul.blr97@gmail.com>
Cc: devel@driverdev.osuosl.org, insop.song@gainspeed.com
Subject: Re: [PATCH] staging: gs_fpgaboot: get bus width input
Date: Wed, 22 Jul 2020 08:32:54 +0200 [thread overview]
Message-ID: <20200722063254.GA2715521@kroah.com> (raw)
In-Reply-To: <20200722062711.GA3300@rahulg-ThinkPad-T450>
On Wed, Jul 22, 2020 at 11:57:11AM +0530, Rahul Gottipati wrote:
> On Tue, Jul 21, 2020 at 08:05:33PM +0200, Greg KH wrote:
> > On Tue, Jul 21, 2020 at 11:32:03PM +0530, Rahul Gottipati wrote:
> > > This adds a module parameter to get the program bus width as an
> > > input rather than hardcoding it, and checks off a TODO item.
> >
> > Ick, no, module parameters are from the 1990's, please make this dynamic
> > somehow.
>
> Hi, I'm pretty new to this. Do you have any ideas/suggestions on how to
> do this dynamically?
It all depends on what the paramater is, what it is needed for, and who
would ever need to change it.
So I think it would take a bit of domain-specific knowledge here to
determine that, it's not a general "code cleanup" task.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-07-22 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 18:02 [PATCH] staging: gs_fpgaboot: get bus width input Rahul Gottipati
2020-07-21 18:05 ` Greg KH
2020-07-22 6:27 ` Rahul Gottipati
2020-07-22 6:32 ` Greg KH [this message]
2020-07-22 6:41 ` Rahul Gottipati
2020-07-22 6:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722063254.GA2715521@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=insop.song@gainspeed.com \
--cc=rahul.blr97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).