From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kurt Manucredo <fuzzybritches@protonmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix comparisons - put constant on right side- eudyptula challenge 10
Date: Thu, 18 Feb 2021 19:04:20 +0300 [thread overview]
Message-ID: <20210218160420.GN2087@kadam> (raw)
In-Reply-To: <20210218155422.7-2-fuzzybritches@protonmail.com>
Fix the subject. Don't mention eudyptula.
[PATCH] Staging: rtl8723bs: put constant on right side of comparison
Add a commit message:
Checkpatch complains that the constant needs to be on the right hand
side of the comparion.
On Thu, Feb 18, 2021 at 03:54:40PM +0000, Kurt Manucredo wrote:
> Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
> index 975f2830e29e..089c6ec19373 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
> @@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr)
> struct security_priv *psecpriv = &padapter->securitypriv;
>
> memset(pcur_dot11txpn, 0, 8);
> - if (NULL == StaAddr)
> + if (StaAddr == NULL)
The prefered format for this is actually:
if (!StaAddr)
return;
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2021-02-18 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210218155422.7-1-fuzzybritches@protonmail.com>
2021-02-18 15:54 ` [PATCH] fix comparisons - put constant on right side- eudyptula challenge 10 Kurt Manucredo
2021-02-18 16:04 ` Dan Carpenter [this message]
2021-02-18 16:01 ` [PATCH] fix comparisons - put constant on right side- eudyptula Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218160420.GN2087@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fuzzybritches@protonmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).