From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>, Jules Irenge <jbi.octave@gmail.com>
Cc: devel@driverdev.osuosl.org, f.fainelli@gmail.com,
sbranden@broadcom.com, mchehab+samsung@kernel.org,
outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, eric@anholt.net,
daniela.mormocea@gmail.com,
bcm-kernel-feedback-list@broadcom.com, wahrenst@gmx.net,
dave.stevenson@raspberrypi.org, rjui@broadcom.com,
hverkuil-cisco@xs4all.nl, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix warnings of lines should not end with open parenthesis
Date: Fri, 11 Oct 2019 15:32:22 -0700 [thread overview]
Message-ID: <28ed468bc58c0d0e92f459b45d8e43cd3d1458b2.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1910112320550.3284@hadrien>
On Fri, 2019-10-11 at 23:23 +0200, Julia Lawall wrote:
> On Fri, 11 Oct 2019, Jules Irenge wrote:
> > Fix warning of lines should not end with open parenthesis.
> > Issue detected by checkpatch tool.
[]
> > diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
[]
> > @@ -337,9 +337,8 @@ static void buffer_cb(struct vchiq_mmal_instance *instance,
> > if (is_capturing(dev)) {
> > v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,
> > "Grab another frame");
> > - vchiq_mmal_port_parameter_set(
> > - instance,
> > - dev->capture.camera_port,
> > + vchiq_mmal_port_parameter_set(instance,
> > + dev->capture.camera_port,
> > MMAL_PARAMETER_CAPTURE,
> > &dev->capture.frame_count,
> > sizeof(dev->capture.frame_count));
>
> You can't reduce the indentation on the function call. It has to stay
> clearly in the if branch.
>
> If you adjust the indentation of some of the arguments, you have to do so
> to all of the arguments.
>
> Similar issues arise below. There may be no way to make some of the calls
> look nice without a more severe reorganization of the code.
My suggestion would be to shorten the vchiq_mmal_port_parameter_set
function name (29 chars is just too long) and pass dev instead of
dev->instance as the first argument to this function.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2019-10-11 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 21:16 [PATCH] staging: vc04_services: fix warnings of lines should not end with open parenthesis Jules Irenge
2019-10-11 21:23 ` [Outreachy kernel] " Julia Lawall
2019-10-11 22:32 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28ed468bc58c0d0e92f459b45d8e43cd3d1458b2.camel@perches.com \
--to=joe@perches.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniela.mormocea@gmail.com \
--cc=dave.stevenson@raspberrypi.org \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jbi.octave@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mchehab+samsung@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).