From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, Aaro Koskinen <aaro.koskinen@iki.fi>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ralf Baechle <ralf@linux-mips.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] stating: octeon: Drop on uncorrectable alignment or FCS error
Date: Mon, 12 Oct 2020 14:23:56 +0200 [thread overview]
Message-ID: <49fae268-c88f-d4e8-6a03-60b69b060557@nokia.com> (raw)
In-Reply-To: <20201009122459.GP1042@kadam>
Hello Dan,
On 09/10/2020 14:24, Dan Carpenter wrote:
> On Fri, Oct 09, 2020 at 11:46:05AM +0200, Alexander A Sverdlin wrote:
>> --- a/drivers/staging/octeon/ethernet-rx.c
>> +++ b/drivers/staging/octeon/ethernet-rx.c
>> @@ -69,14 +69,16 @@ static inline int cvm_oct_check_rcv_error(struct cvmx_wqe *work)
>> else
>> port = work->word1.cn38xx.ipprt;
>>
>> - if ((work->word2.snoip.err_code == 10) && (work->word1.len <= 64)) {
>> + if ((work->word2.snoip.err_code == 10) && (work->word1.len <= 64))
>> /*
>> * Ignore length errors on min size packets. Some
>> * equipment incorrectly pads packets to 64+4FCS
>> * instead of 60+4FCS. Note these packets still get
>> * counted as frame errors.
>> */
>> - } else if (work->word2.snoip.err_code == 5 ||
>> + return 0;
>> +
>> + if (work->word2.snoip.err_code == 5 ||
>> work->word2.snoip.err_code == 7) {
> This line is indented to match the old code and it no longer matches.
> (Please update the whitespace).
thanks to your comment I took a fresh look onto the patch and found a logic error
in the change. Please ignore the whole patch for now.
>> /*
>> * We received a packet with either an alignment error
--
Best regards,
Alexander Sverdlin.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2020-10-12 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 9:46 [PATCH] staging: octeon: repair "fixed-link" support Alexander A Sverdlin
2020-10-09 9:46 ` [PATCH] stating: octeon: Drop on uncorrectable alignment or FCS error Alexander A Sverdlin
2020-10-09 12:24 ` Dan Carpenter
2020-10-12 12:23 ` Alexander Sverdlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49fae268-c88f-d4e8-6a03-60b69b060557@nokia.com \
--to=alexander.sverdlin@nokia.com \
--cc=aaro.koskinen@iki.fi \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).