From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 300BEC433DF for ; Wed, 1 Jul 2020 01:25:06 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0259A2074D for ; Wed, 1 Jul 2020 01:25:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="pzg2MyzZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0259A2074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C762D882A0; Wed, 1 Jul 2020 01:25:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aegOjEP0yHT7; Wed, 1 Jul 2020 01:25:05 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 3267C88280; Wed, 1 Jul 2020 01:25:05 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 452C51BF34E for ; Wed, 1 Jul 2020 01:25:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 41C6988280 for ; Wed, 1 Jul 2020 01:25:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bOD1KlSrPN0i for ; Wed, 1 Jul 2020 01:25:03 +0000 (UTC) X-Greylist: delayed 00:08:14 by SQLgrey-1.7.6 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by whitealder.osuosl.org (Postfix) with ESMTP id F238688191 for ; Wed, 1 Jul 2020 01:25:02 +0000 (UTC) Received: from [192.168.1.14] (unknown [76.104.235.235]) by linux.microsoft.com (Postfix) with ESMTPSA id E33F920B717A; Tue, 30 Jun 2020 18:16:47 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E33F920B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1593566208; bh=tyQLy+aBttVw9vIO6s5YDhQ/J3ovQY5y7J2ptg9TN8A=; h=From:Subject:To:Cc:References:Date:In-Reply-To:From; b=pzg2MyzZrLin8Ghn9FRoEko6Tixa7LuU43hPxil/mrXu3zNQtIw/SbfIHJY01BsEV //C4DBit5r5NEJL7M2xv5He/EqsPslm2dYNkvNn8H+OHCE3ecGS2rwNzNbONyZypCX hkOmbxwvJJUwL/tDTGFo1nbCBd1wF+nU6Z90sK4c= From: Jordan Hand Subject: Re: [PATCH] media: ipu3: add a module to probe sensors via ACPI To: Heikki Krogerus , Mauro Carvalho Chehab References: <12fbe3f5c6a16c5f3447adbc09fe27ceb2b16823.1589625807.git.mchehab+huawei@kernel.org> <20200517103659.GS17578@paasikivi.fi.intel.com> <20200520094400.5137e7f2@coco.lan> <20200520082608.GV20066@paasikivi.fi.intel.com> <20200520131830.3ff45919@coco.lan> <20200522115736.10cca8eb@coco.lan> <20200526143110.GC3284396@kuha.fi.intel.com> Message-ID: <6c24193c-0ba4-7c6e-1711-8221ee133826@linux.microsoft.com> Date: Tue, 30 Jun 2020 18:16:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200526143110.GC3284396@kuha.fi.intel.com> Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:STAGING SUBSYSTEM" , Greg Kroah-Hartman , Andy Shevchenko , Sakari Ailus , Bingbu Cao , Tian Shu Qiu , Linux Media Mailing List Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On 5/26/20 7:31 AM, Heikki Krogerus wrote: > On Fri, May 22, 2020 at 11:57:36AM +0200, Mauro Carvalho Chehab wrote: >> Em Thu, 21 May 2020 11:00:19 +0300 >> Andy Shevchenko escreveu: >> >>> +Cc: Heikki (swnode expert) >>> >>> On Wed, May 20, 2020 at 2:19 PM Mauro Carvalho Chehab >>> wrote: >>>> Em Wed, 20 May 2020 11:26:08 +0300 >>>> Sakari Ailus escreveu: >>> >>> ... >>> >>>> As I said, the problem is not probing the sensor via ACPI, but, instead, >>>> to be able receive platform-specific data. >>> >>> There is no problem with swnodes, except missing parts (*). >>> I have Skylake laptop with IPU3 and with half-baked ACPI tables, but >>> since we have drivers in place with fwnode support, we only need to >>> recreate fwnode graph in some board file to compensate the gap in >>> ACPI. >>> >>> *) Missing part is graph support for swnodes. With that done it will >>> be feasible to achieve the rest. >>> I forgot if we have anything for this already done. Heikki? >> >> Hmm... I guess I should try this approach. I never heard about swnodes >> before. Do you have already some patch with the needed swnodes setup, >> and the missing parts to recreate the fwnode graph? > > Here you go. > For anyone interested, I have taken Heikki's patch and attempted to use swnodes to patch the incomplete dsdt on my laptop to use with ipu3; the code is currently in a github repo[1]. In particular, patches 1, 2, and 3 setup the software_node infrastructure. Patch 5 shows how we might use software nodes where ACPI fails. My sensor driver (in patch 4) doesn't actually work right now which is why I haven't brought any of this to the mailing list yet, but that's another story :) I would just submit a patchset, but since my sensor driver doesn't work, I can't gully test the rest of it. But if someone has a system where the drivers in question are upstream and work, something like this could be a good path forward. - Jordan [1] https://github.com/jhand2/surface-camera/tree/master/patches _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel