From: Ian Abbott <abbotti@mev.co.uk>
To: Greg KH <gregkh@linuxfoundation.org>,
Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: devel@driverdev.osuosl.org, saurav.girepunje@hotmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: driver: Remove condition with no effect
Date: Mon, 13 Jul 2020 14:41:19 +0100 [thread overview]
Message-ID: <7653a794-d5ed-5d9f-95af-745a88769092@mev.co.uk> (raw)
In-Reply-To: <20200713133438.GA3122574@kroah.com>
On 13/07/2020 14:34, Greg KH wrote:
> On Sun, Jul 12, 2020 at 12:36:28PM +0530, Saurav Girepunje wrote:
>> Remove below warning in das1800.c
>> WARNING: possible condition with no effect (if == else)
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>> ---
>> drivers/staging/comedi/drivers/das1800.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
>> index f16aa7e9f4f3..7ab72e83d3d0 100644
>> --- a/drivers/staging/comedi/drivers/das1800.c
>> +++ b/drivers/staging/comedi/drivers/das1800.c
>> @@ -1299,12 +1299,6 @@ static int das1800_attach(struct comedi_device *dev,
>> outb(DAC(i), dev->iobase + DAS1800_SELECT);
>> outw(0, dev->iobase + DAS1800_DAC);
>> }
>> - } else if (board->id == DAS1800_ID_AO) {
>> - /*
>> - * 'ao' boards have waveform analog outputs that are not
>> - * currently supported.
>> - */
>> - s->type = COMEDI_SUBD_UNUSED;
>
> What gave that warning? The comment should show you why this is good to
> keep as-is, right?
One option is to move the comment into the '} else {' part that follows
this part.
--
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-07-13 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 7:06 [PATCH] Staging: comedi: driver: Remove condition with no effect Saurav Girepunje
2020-07-13 13:34 ` Greg KH
2020-07-13 13:41 ` Ian Abbott [this message]
2020-07-18 17:23 ` SAURAV GIREPUNJE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7653a794-d5ed-5d9f-95af-745a88769092@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).