From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Driver Development <devel@driverdev.osuosl.org>,
Device Tree <devicetree@vger.kernel.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Renesas SoC <linux-renesas-soc@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Media <linux-media@vger.kernel.org>
Subject: Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC
Date: 09 Mar 2020 10:31:01 +0900 [thread overview]
Message-ID: <87r1y2wbze.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20200306134546.GE4878@pendragon.ideasonboard.com>
Hi
> > > Those clocks are part of the CSI-2 protocol and also don't need to be
> > > explicitly controlled. As far as I can tell from a quick check of the
> > > ADV7482 documentation, only the I2S MCLK is a general-purpose clock that
> > > needs to be exposed.
(snip)
> > Do you know, by chance, which of the snd_soc* callbacks should be used to
> > implement setting of the MCLK? The one in snd_soc_component_driver or
> > snd_soc_dai_driver->ops (snd_soc_dai_ops)?
> >
> > Or how the userspace interface looks like? Or, if there is no userspace
> > interface for this, how the MCLK is supposed to be set? Through mclk-fs?
>
> I'm afraid my knowledge of the sound subsystem is limited. Morimoto-san
> is the main developer and maintainer of Renesas sound drivers.
> Morimoto-sensei, would you have an answer to that question ? :-)
In my quick check, it goes to AUDIO_CLKC.
If so, you can update rcar_sound::clocks.
&rcar_sound {
...
- /* update <audio_clk_b> to <cs2000> */
+ /* update <audio_clk_b> to <cs2000>,
+ * <audio_clk_c> to <adv748x> */
clocks = <&cpg CPG_MOD 1005>,
...
<&audio_clk_a>, <&cs2000>,
- <&audio_clk_c>,
+ <&adv748x>,
<&cpg CPG_CORE CPG_AUDIO_CLK_I>;
Thank you for your help !!
Best regards
---
Kuninori Morimoto
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-03-09 1:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 14:19 [PATCH 0/8] media: i2c: adv748x: add support for HDMI audio Alex Riesen
2020-01-13 14:15 ` [PATCH 1/8] media: adv748x: add a device-specific wrapper for register block read Alex Riesen
2020-01-13 14:15 ` [PATCH 2/8] media: adv748x: add audio mute control and output selection ioctls Alex Riesen
2020-03-13 8:16 ` Hans Verkuil
2020-03-13 10:26 ` Alex Riesen
2020-03-13 10:52 ` Hans Verkuil
2020-03-13 11:00 ` Alex Riesen
2020-01-13 14:15 ` [PATCH 3/8] media: adv748x: add log_status ioctl Alex Riesen
2020-01-13 14:15 ` [PATCH 4/8] media: adv748x: reserve space for the audio (I2S) port in the driver structures Alex Riesen
2020-01-13 14:15 ` [PATCH 5/8] media: adv748x: add an ASoC DAI definition to the driver Alex Riesen
2020-01-13 14:15 ` [PATCH 6/8] media: adv748x: reduce amount of code for bitwise modification of device registers Alex Riesen
2020-01-13 14:15 ` [PATCH 7/8] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM) Alex Riesen
2020-01-13 22:32 ` Rob Herring
2020-01-13 14:15 ` [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC Alex Riesen
2020-03-02 12:28 ` Geert Uytterhoeven
2020-03-02 13:40 ` Alex Riesen
2020-03-02 13:47 ` Geert Uytterhoeven
2020-03-02 15:07 ` Alex Riesen
2020-03-02 15:32 ` Geert Uytterhoeven
2020-03-02 16:09 ` Alex Riesen
2020-03-02 16:13 ` Geert Uytterhoeven
2020-03-05 14:36 ` Alex Riesen
2020-03-06 12:21 ` Geert Uytterhoeven
2020-03-06 13:16 ` Laurent Pinchart
2020-03-06 13:41 ` Alex Riesen
2020-03-06 13:45 ` Laurent Pinchart
2020-03-09 1:31 ` Kuninori Morimoto [this message]
2020-03-09 11:09 ` Alex Riesen
2020-03-10 1:07 ` Kuninori Morimoto
2020-03-10 8:17 ` Alex Riesen
2020-03-10 10:39 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1y2wbze.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).