From: Robert Foss <robert.foss@linaro.org>
To: Xin Ji <xji@analogixsemi.com>
Cc: devel@driverdev.osuosl.org, Nicolas Boichat <drinkcat@google.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Sheng Pan <span@analogixsemi.com>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
Vasily Khoruzhick <anarsoul@gmail.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Torsten Duwe <duwe@lst.de>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel@ffwll.ch>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Sam Ravnborg <sam@ravnborg.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v4 2/3] drm/bridge: anx7625: fix not correct return value
Date: Thu, 4 Feb 2021 13:28:30 +0100 [thread overview]
Message-ID: <CAG3jFyuAixFQ0L_2zw_8Ze3cF11PFMm-sN6ZQR7=opEjWV1nNw@mail.gmail.com> (raw)
In-Reply-To: <23b62a447364a9047f0b1b144557e8d95f6ad7f7.1611802321.git.xji@analogixsemi.com>
Hi Xin,
On Thu, 28 Jan 2021 at 04:12, Xin Ji <xji@analogixsemi.com> wrote:
>
> At some time, the original code may return non zero value, force return 0
> if operation finished
Missing "." at end of line.
Other than that, this patch looks fine. Feel free to add my r-b.
Reviewed-by: Robert Foss <robert.foss@linaro.org>
>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 65cc059..04536cc 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -189,10 +189,10 @@ static int wait_aux_op_finish(struct anx7625_data *ctx)
> AP_AUX_CTRL_STATUS);
> if (val < 0 || (val & 0x0F)) {
> DRM_DEV_ERROR(dev, "aux status %02x\n", val);
> - val = -EIO;
> + return -EIO;
> }
>
> - return val;
> + return 0;
> }
>
> static int anx7625_video_mute_control(struct anx7625_data *ctx,
> --
> 2.7.4
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2021-02-04 12:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 3:07 [PATCH v4 0/3] Add MIPI rx DPI support Xin Ji
2021-01-28 3:09 ` [PATCH v4 2/3] drm/bridge: anx7625: fix not correct return value Xin Ji
2021-02-04 12:28 ` Robert Foss [this message]
2021-02-05 11:40 ` Xin Ji
2021-01-28 3:10 ` [PATCH v4 3/3] drm/bridge: anx7625: add MIPI DPI input feature support Xin Ji
2021-02-05 12:33 ` Robert Foss
2021-02-18 5:40 ` Xin Ji
2021-02-24 9:55 ` Hsin-Yi Wang
2021-02-24 10:42 ` Hsin-Yi Wang
2021-02-25 3:08 ` Xin Ji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG3jFyuAixFQ0L_2zw_8Ze3cF11PFMm-sN6ZQR7=opEjWV1nNw@mail.gmail.com' \
--to=robert.foss@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=anarsoul@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@google.com \
--cc=duwe@lst.de \
--cc=hsinyi@chromium.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=narmstrong@baylibre.com \
--cc=sam@ravnborg.org \
--cc=span@analogixsemi.com \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).