From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
linux-pwm@vger.kernel.org,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Scott Branden" <sbranden@broadcom.com>,
devicetree <devicetree@vger.kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>, "Ray Jui" <rjui@broadcom.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-input <linux-input@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
"Stefan Wahren" <wahrenst@gmx.net>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-clk <linux-clk@vger.kernel.org>,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 01/10] firmware: raspberrypi: Introduce rpi_firmware_put()
Date: Thu, 22 Oct 2020 21:46:41 +0300 [thread overview]
Message-ID: <CAHp75Vej4UfsySRB6qXL7fFN7SjnTjy=p4Xkn1xBO0YOFy-kcQ@mail.gmail.com> (raw)
In-Reply-To: <20201022155858.20867-2-nsaenzjulienne@suse.de>
On Thu, Oct 22, 2020 at 9:06 PM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> When unbinding the firmware device we need to make sure it has no
> consumers left. Otherwise we'd leave them with a firmware handle
> pointing at freed memory.
>
> Keep a reference count of all consumers and make sure they all finished
> unbinding before we do.
Wait, if it's a device, why do we need all these?
get_device() / put_device() along with module_get() / module_put()
should be sufficient, no?
--
With Best Regards,
Andy Shevchenko
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-10-22 18:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 15:58 [PATCH v2 00/10] Raspberry Pi PoE HAT fan support Nicolas Saenz Julienne
2020-10-22 15:58 ` [PATCH v2 01/10] firmware: raspberrypi: Introduce rpi_firmware_put() Nicolas Saenz Julienne
2020-10-22 18:46 ` Andy Shevchenko [this message]
2020-10-26 16:26 ` Nicolas Saenz Julienne
2020-10-22 15:58 ` [PATCH v2 02/10] clk: bcm: rpi: Release firmware handle on unbind Nicolas Saenz Julienne
2020-10-22 15:58 ` [PATCH v2 03/10] gpio: raspberrypi-exp: " Nicolas Saenz Julienne
2020-10-26 14:40 ` Bartosz Golaszewski
2020-10-26 14:42 ` Nicolas Saenz Julienne
2020-10-26 14:45 ` Bartosz Golaszewski
2020-10-22 15:58 ` [PATCH v2 04/10] reset: raspberrypi: " Nicolas Saenz Julienne
2020-10-22 15:58 ` [PATCH v2 05/10] soc: bcm: raspberrypi-power: " Nicolas Saenz Julienne
2020-10-26 14:31 ` Nicolas Saenz Julienne
2020-10-22 15:58 ` [PATCH v2 06/10] staging: vchiq: " Nicolas Saenz Julienne
2020-10-22 15:58 ` [PATCH v2 07/10] input: raspberrypi-ts: Release firmware handle when not needed Nicolas Saenz Julienne
2020-10-22 15:58 ` [PATCH v2 08/10] dt-bindings: pwm: Add binding for RPi firmware PWM bus Nicolas Saenz Julienne
2020-10-30 15:37 ` Rob Herring
2020-10-22 15:58 ` [PATCH v2 09/10] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support Nicolas Saenz Julienne
2020-10-22 15:58 ` [PATCH v2 10/10] pwm: Add Raspberry Pi Firmware based PWM bus Nicolas Saenz Julienne
2020-10-22 18:53 ` Andy Shevchenko
2020-10-26 14:02 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vej4UfsySRB6qXL7fFN7SjnTjy=p4Xkn1xBO0YOFy-kcQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=p.zabel@pengutronix.de \
--cc=rjui@broadcom.com \
--cc=sboyd@kernel.org \
--cc=sbranden@broadcom.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).