driverdev-devel.linuxdriverproject.org archive mirror
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Valdis Kl??tnieks <valdis.kletnieks@vt.edu>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Sasha Levin <alexander.levin@microsoft.com>,
	devel@driverdev.osuosl.org,  kbuild-all@01.org
Subject: [staging:staging-testing 268/273] drivers/staging/exfat/exfat_super.c:3491:2-7: WARNING: NULL check before some freeing functions is not needed. (fwd)
Date: Tue, 3 Sep 2019 07:00:55 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1909030659490.3228@hadrien> (raw)

You can drop the if on line 3490.

julia

---------- Forwarded message ----------
Date: Tue, 3 Sep 2019 04:28:35 +0800
From: kbuild test robot <lkp@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: [staging:staging-testing 268/273]
    drivers/staging/exfat/exfat_super.c:3491:2-7: WARNING: NULL check before
    some freeing functions is not needed.

CC: kbuild-all@01.org
CC: devel@driverdev.osuosl.org
TO: "Valdis Kl??tnieks" <valdis.kletnieks@vt.edu>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Sasha Levin <alexander.levin@microsoft.com>

tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing
head:   544b3e7fd2d39b571298c64000423df21b912a3b
commit: c48c9f7ff32b8b3965a08e40eb6763682d905b5d [268/273] staging: exfat: add exfat filesystem code to staging
:::::: branch date: 2 hours ago
:::::: commit date: 4 days ago

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>

>> drivers/staging/exfat/exfat_super.c:3491:2-7: WARNING: NULL check before some freeing functions is not needed.
--
>> drivers/staging/exfat/exfat_super.c:2699:26-33: WARNING opportunity for kmemdup

git remote add staging https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/staging.git
git remote update staging
git checkout c48c9f7ff32b8b3965a08e40eb6763682d905b5d
vim +3491 drivers/staging/exfat/exfat_super.c

c48c9f7ff32b8b Valdis Kletnieks 2019-08-28  3487
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28  3488  static void exfat_destroy_inode(struct inode *inode)
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28  3489  {
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28  3490  	if (EXFAT_I(inode)->target)
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28 @3491  		kfree(EXFAT_I(inode)->target);
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28  3492  	EXFAT_I(inode)->target = NULL;
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28  3493
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28  3494  	kmem_cache_free(exfat_inode_cachep, EXFAT_I(inode));
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28  3495  }
c48c9f7ff32b8b Valdis Kletnieks 2019-08-28  3496

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

                 reply	other threads:[~2019-09-03  5:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1909030659490.3228@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=alexander.levin@microsoft.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@01.org \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).