From: Julia Lawall <julia.lawall@lip6.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com,
Cristiane Naves <cristianenavescardoso09@gmail.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging: octeon: Remove unneeded variable
Date: Mon, 28 Oct 2019 09:36:04 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1910280934430.2348@hadrien> (raw)
In-Reply-To: <20191028082732.GE1944@kadam>
On Mon, 28 Oct 2019, Dan Carpenter wrote:
> On Sat, Oct 26, 2019 at 07:24:53PM -0300, Cristiane Naves wrote:
> > Remove unneeded variable used to store return value. Issue found by
> > coccicheck.
> >
> > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> > ---
> > drivers/staging/octeon/octeon-stubs.h | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> > index b07f5e2..d53bd801 100644
> > --- a/drivers/staging/octeon/octeon-stubs.h
> > +++ b/drivers/staging/octeon/octeon-stubs.h
> > @@ -1387,9 +1387,7 @@ static inline cvmx_pko_status_t cvmx_pko_send_packet_finish(uint64_t port,
> > uint64_t queue, union cvmx_pko_command_word0 pko_command,
> > union cvmx_buf_ptr packet, cvmx_pko_lock_t use_locking)
> > {
> > - cvmx_pko_status_t ret = 0;
> > -
> > - return ret;
> > + return 0;
>
> What is the point of this function anyway?
Given that it is in octeon-stubs.h, it seems that the point is to get the
code to compile when COMPILE_TEST is set. There is a real definition in
arch/mips/include/asm/octeon/cvmx-pko.h
julia
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-10-28 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 22:24 [PATCH] staging: octeon: Remove unneeded variable Cristiane Naves
2019-10-28 8:27 ` Dan Carpenter
2019-10-28 8:36 ` Julia Lawall [this message]
2019-10-28 8:40 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910280934430.2348@hadrien \
--to=julia.lawall@lip6.fr \
--cc=cristianenavescardoso09@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).