From: Julia Lawall <julia.lawall@inria.fr>
To: Simran Singhal <singhalsimran0@gmail.com>
Cc: driverdevel <devel@driverdev.osuosl.org>,
Greg KH <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH v2] staging: kpc2000: Removing a blank line
Date: Wed, 25 Mar 2020 12:37:56 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.2003251234560.2444@hadrien> (raw)
In-Reply-To: <20200325095407.GA3788@simran-Inspiron-5558>
On Wed, 25 Mar 2020, Simran Singhal wrote:
> This patch fixes the checkpatch warning by removing a blank
> line.
> CHECK: Please don't use multiple blank lines
The subject line and the log message should be written in the imperative.
So that would be Remove, rather than Removing for the subject line.
The log message should first say what you did to fix the problem and why.
How the problem was found can come afterwards. So you should not start
with "This patch fixes the checkpatch warning by". "This patch" is not
useful, because it is obvious that it is a patch, based on the subject
line. "fixes" does not given any information about what is done or why.
"the checkpatch warning" is useful, but it's not what one wants to see
first.
julia
>
> Signed-off-by: Simran Singhal <singhalsimran0@gmail.com>
> ---
> Changes in v2:
> - Make the subject and commit message correct by mentioning that
> this patch specifically removes a blank line.
>
> drivers/staging/kpc2000/kpc2000/pcie.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/kpc2000/kpc2000/pcie.h b/drivers/staging/kpc2000/kpc2000/pcie.h
> index cb815c30faa4..f1fc91b4c704 100644
> --- a/drivers/staging/kpc2000/kpc2000/pcie.h
> +++ b/drivers/staging/kpc2000/kpc2000/pcie.h
> @@ -6,7 +6,6 @@
> #include "../kpc.h"
> #include "dma_common_defs.h"
>
> -
> /* System Register Map (BAR 1, Start Addr 0)
> *
> * BAR Size:
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200325095407.GA3788%40simran-Inspiron-5558.
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2020-03-25 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 9:54 [PATCH v2] staging: kpc2000: Removing a blank line Simran Singhal
2020-03-25 11:37 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2003251234560.2444@hadrien \
--to=julia.lawall@inria.fr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=singhalsimran0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).