From: Jules Irenge <jbi.octave@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com,
Jules Irenge <jbi.octave@gmail.com>,
abbotti@mev.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: comedi: rewrite macro function with GNU extension typeof
Date: Tue, 5 Nov 2019 11:07:37 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.1911051106520.11074@ninjahub.org> (raw)
In-Reply-To: <20191104164653.GA2281588@kroah.com>
On Mon, 4 Nov 2019, Greg KH wrote:
> On Mon, Nov 04, 2019 at 04:33:31PM +0000, Jules Irenge wrote:
> > Rewrite macro function with the GNU extension typeof
> > to remove a possible side-effects of MACRO argument reuse "x".
> > - Problem could rise if arguments have different types
> > and different use though.
>
> You can not just get away with a potential problem by documenting it :)
>
> You might have just broken this. Why are you trying to "fix" something
> that is not broken?
>
> What is wrong with the code as-is?
>
> thanks,
>
> greg k-h
>
Again I made a lot of mistake. I will be more carefull.
Thanks for the feedback
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-11-05 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 16:33 [PATCH v2] staging: comedi: rewrite macro function with GNU extension typeof Jules Irenge
2019-11-04 16:46 ` Greg KH
2019-11-05 11:07 ` Jules Irenge [this message]
2019-11-04 17:03 ` Ian Abbott
2019-11-04 20:46 ` Greg KH
2019-11-05 11:00 ` Jules Irenge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1911051106520.11074@ninjahub.org \
--to=jbi.octave@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).