From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Marcelo Diop-Gonzalez <marcgonzalez@google.com>,
gregkh@linuxfoundation.org, wahrenst@gmx.net
Cc: devel@driverdev.osuosl.org, linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] staging: vchiq: call unregister_chrdev_region() when driver registration fails
Date: Wed, 04 Dec 2019 21:13:21 +0100 [thread overview]
Message-ID: <f0f68c001a94f72b05d188f1089f24e78552f276.camel@suse.de> (raw)
In-Reply-To: <20191203153921.70540-1-marcgonzalez@google.com>
[-- Attachment #1.1: Type: text/plain, Size: 1075 bytes --]
On Tue, 2019-12-03 at 10:39 -0500, Marcelo Diop-Gonzalez wrote:
> This undoes the previous call to alloc_chrdev_region() on failure,
> and is probably what was meant originally given the label name.
>
> Signed-off-by: Marcelo Diop-Gonzalez <marcgonzalez@google.com>
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index 02148a24818a..4458c1e60fa3 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -3309,7 +3309,7 @@ static int __init vchiq_driver_init(void)
> return 0;
>
> region_unregister:
> - platform_driver_unregister(&vchiq_driver);
> + unregister_chrdev_region(vchiq_devid, 1);
>
> class_destroy:
> class_destroy(vchiq_class);
Thanks!
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2019-12-04 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 15:39 [PATCH] staging: vchiq: call unregister_chrdev_region() when driver registration fails Marcelo Diop-Gonzalez
2019-12-03 17:48 ` Dan Carpenter
2019-12-04 20:13 ` Nicolas Saenz Julienne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0f68c001a94f72b05d188f1089f24e78552f276.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=marcgonzalez@google.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).