From: Joe Perches <joe@perches.com>
To: Randy Dunlap <rdunlap@infradead.org>, Greg KH <greg@kroah.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Valdis Kletnieks <valdis.kletnieks@vt.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>
Subject: Re: linux-next: Tree for Sep 2 (exfat)
Date: Mon, 02 Sep 2019 11:11:45 -0700 [thread overview]
Message-ID: <f7f8f751e77578edb88c0d9888930de3f3b60670.camel@perches.com> (raw)
In-Reply-To: <13e2db80-0c89-0f36-6876-f9639f0d30ab@infradead.org>
On Mon, 2019-09-02 at 11:07 -0700, Randy Dunlap wrote:
> On 9/2/19 10:46 AM, Greg KH wrote:
> > On Mon, Sep 02, 2019 at 10:39:39AM -0700, Randy Dunlap wrote:
> > > On 9/2/19 5:43 AM, Stephen Rothwell wrote:
> > > > Hi all,
> > > >
> > > > News: I will only be doing 2 more releases before I leave for Kernel
> > > > Summit (there may be some reports on Thursday, but I doubt I will have
> > > > time to finish the full release) and then no more until Sept 30.
> > > >
> > > > Changes since 20190830:
> > > >
> > >
> > > Hi,
> > > I am seeing lots of exfat build errors when CONFIG_BLOCK is not set/enabled.
> > > Maybe its Kconfig should also say
> > > depends on BLOCK
> > > ?
> >
> > Here's what I committed to my tree:
> >
> >
> > From e2b880d3d1afaa5cad108c29be3e307b1917d195 Mon Sep 17 00:00:00 2001
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Date: Mon, 2 Sep 2019 19:45:06 +0200
> > Subject: staging: exfat: make exfat depend on BLOCK
> >
> > This should fix a build error in some configurations when CONFIG_BLOCK
> > is not selected. Also properly set the dependancy for no FAT support at
> > the same time.
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> That works. Thanks.
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
>
> > ---
> > drivers/staging/exfat/Kconfig | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/staging/exfat/Kconfig b/drivers/staging/exfat/Kconfig
> > index f52129c67f97..290dbfc7ace1 100644
> > --- a/drivers/staging/exfat/Kconfig
> > +++ b/drivers/staging/exfat/Kconfig
> > @@ -1,11 +1,13 @@
> > config EXFAT_FS
> > tristate "exFAT fs support"
> > + depends on BLOCK
> > select NLS
> > help
> > This adds support for the exFAT file system.
> >
> > config EXFAT_DONT_MOUNT_VFAT
> > bool "Prohibit mounting of fat/vfat filesysems by exFAT"
> > + depends on EXFAT_FS
> > default y
> > help
> > By default, the exFAT driver will only mount exFAT filesystems, and refuse
I think this last one is backwards and should be
config EXFAT_ALLOW_MOUNT_VFAT
and
default n
>
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-09-02 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190902224310.208575dc@canb.auug.org.au>
2019-09-02 17:39 ` linux-next: Tree for Sep 2 (exfat) Randy Dunlap
2019-09-02 17:42 ` Greg KH
2019-09-02 17:46 ` Greg KH
2019-09-02 18:07 ` Randy Dunlap
2019-09-02 18:11 ` Joe Perches [this message]
2019-09-02 18:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7f8f751e77578edb88c0d9888930de3f3b60670.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).