From: Arnaldo Carvalho de Melo <acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Cody Schafer <cody-QpQMm/NnEELQT0dZR+AlfA@public.gmane.org>
Cc: "Elliott,
Robert (Server Storage)" <Elliott-VXdhtT5mjnY@public.gmane.org>,
dwarves-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: pahole DW_TAG_mutable_type
Date: Mon, 27 Apr 2015 21:45:50 -0300 [thread overview]
Message-ID: <20150428004550.GG16849@kernel.org> (raw)
In-Reply-To: <CA+E_MsxY9sC2Eh2gSx5U1z7Ay-nPOnC3ZraaLzcopkSvwX6MJg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Em Mon, Apr 27, 2015 at 07:47:02PM -0400, Cody Schafer escreveu:
> On Mon, Apr 27, 2015 at 12:25 PM, Elliott, Robert (Server Storage)
> <Elliott-VXdhtT5mjnY@public.gmane.org> wrote:
> >
> > Recent versions of libdwarves have removed DW_TAG_mutable_type, which
> > affects dwarves_fprintf.c.
> > http://www.spinics.net/lists/dwarves/msg00121.html
This line you refer to doesn't remove DW_TAG_mutable_type, it removes a
line that references it.
> > This causes an error building pahole, which has a copy of dwarves_fprintf.c:
> >
> >
> > [ 8%] Building C object CMakeFiles/dwarves.dir/dwarves_fprintf.o
> > /home/orange/sw/pahole/dwarves_fprintf.c:77:3: error: 'DW_TAG_mutable_type' undeclared here (not in a function)
> > [DW_TAG_mutable_type] = "mutable_type",
> > ^
Not really, the problem lies elsewhere, i.e. DW_TAG_mutable_type not
being defined, Mark's solution was to just remove the only reference we
had to it, in dwarves_fprintf.c
> > /home/orange/sw/pahole/dwarves_fprintf.c:77:2: error: array index in initializer not of integer type
> > [DW_TAG_mutable_type] = "mutable_type",
> > ^
> > /home/orange/sw/pahole/dwarves_fprintf.c:77:2: error: (near initialization for 'dwarf_tag_names')
> > make[2]: *** [CMakeFiles/dwarves.dir/dwarves_fprintf.o] Error 1
> >
> >
> > Deleting that line seems to fix the problem.
So yes, what you did seems to be what is required.
> I'm not upstream, I'm just some guy with a github repo of pahole :)
Are there any outstanding patches in your repo that you think I should
pull?
> Redirecting this to the right mailing list, might already be fixed
> upstream (https://git.kernel.org/cgit/devel/pahole/pahole.git), I
> haven't checked.
>
> Probably a good idea to add the mailing list (and git url) to the
> README to make it more discover-able for folks that find the source
> code in other places.
Right, will try and do this tomorrow, make sure the github repo is in
synch with the kernel.org one, etc.
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe dwarves" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-04-28 0:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 23:47 pahole DW_TAG_mutable_type Cody Schafer
[not found] ` <CA+E_MsxY9sC2Eh2gSx5U1z7Ay-nPOnC3ZraaLzcopkSvwX6MJg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-28 0:45 ` Arnaldo Carvalho de Melo [this message]
[not found] ` <20150428004550.GG16849-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-04-28 1:06 ` Cody Schafer
[not found] ` <CA+E_MsxSnuJyKZRhd3B9WHeH+wBk5VB22Y0KBC3_=J34wyhkeQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-28 1:15 ` Elliott, Robert (Server Storage)
2015-04-28 1:27 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150428004550.GG16849@kernel.org \
--to=acme-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=Elliott-VXdhtT5mjnY@public.gmane.org \
--cc=cody-QpQMm/NnEELQT0dZR+AlfA@public.gmane.org \
--cc=dwarves-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).