From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Hao Luo <haoluo@google.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
dwarves@vger.kernel.org, Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH 0/2] pahole: Make encoding percpu vars into BTF optional.
Date: Fri, 18 Sep 2020 17:57:50 -0700 [thread overview]
Message-ID: <CAADnVQL_Qudg34PpgKDz4pObwUZBJfbmKm+NcSLiQf575JcvEQ@mail.gmail.com> (raw)
In-Reply-To: <20200918204058.1030519-1-haoluo@google.com>
On Fri, Sep 18, 2020 at 1:41 PM Hao Luo <haoluo@google.com> wrote:
>
> Previous commit f3d9054ba8ff ("btf_encoder: Teach pahole to store
> percpu variables in vmlinux BTF.") introduced a feature in btf_encoder
> that encodes global symbols in BTF. However, this feature is not
> protected by any flag. In order to avoid surprises after Pahole v1.18
> rolls out, make this feature off by default and enable only upon
> request. On the kernel side, we can add a Kconfig to enable this
> new capability on an opt-in pattern.
I think I've missed some earlier discussions and motivation for opt-in.
Why opt-out is a problem?
I would think the kernel build should always include percpu vars.
next prev parent reply other threads:[~2020-09-19 0:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 20:40 [PATCH 0/2] pahole: Make encoding percpu vars into BTF optional Hao Luo
2020-09-18 20:40 ` [PATCH 1/2] btf_encoder: Make encoding " Hao Luo
2020-09-18 21:24 ` Arnaldo Carvalho de Melo
2020-09-18 21:26 ` Hao Luo
2020-09-18 21:40 ` Arnaldo Carvalho de Melo
2020-09-18 20:40 ` [PATCH 2/2] btf_encoder: Introduce option '--btf_encode_force' Hao Luo
2020-09-19 0:57 ` Alexei Starovoitov [this message]
2020-09-19 4:00 ` [PATCH 0/2] pahole: Make encoding percpu vars into BTF optional Hao Luo
2020-09-21 12:27 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQL_Qudg34PpgKDz4pObwUZBJfbmKm+NcSLiQf575JcvEQ@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=daniel@iogearbox.net \
--cc=dwarves@vger.kernel.org \
--cc=haoluo@google.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).