dwarves.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen-pxSi+dnQzZMxHbG02/KK1g@public.gmane.org>
To: Arnaldo Carvalho de Melo <acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: dwarves-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: codiff misses changes if inline -> not inlined?
Date: Fri, 4 Jan 2008 00:41:40 +0200 (EET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0801040038510.20866@kivilampi-30.cs.helsinki.fi> (raw)
In-Reply-To: <20080103165605.GF29523-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2598 bytes --]

On Thu, 3 Jan 2008, Arnaldo Carvalho de Melo wrote:

> Em Thu, Jan 03, 2008 at 06:45:32PM +0200, Ilpo Järvinen escreveu:
> > On Thu, 3 Jan 2008, Arnaldo Carvalho de Melo wrote:
> > 
> > Now that I automated it for inlines per file, one thing that annoys me a 
> > bit is that it does not keep identical formatting on the last line (it's 
> > fixable of course by some simple sed trickery):
> > 
> > static inline int tcp_may_raise_cwnd(const struct sock *sk, const int 
> > flag)
> > net/ipv4/tcp_input.c:
> >   tcp_prune_queue |  -16
> >  1 function changed, 16 bytes removed
> > 
> > ...versus...
> > 
> > static inline int tcp_may_update_window(const struct tcp_sock *tp,
> > net/ipv4/tcp_input.c:
> >   tcp_disordered_ack |  -18
> >   tcp_ack            |  -76
> >  2 functions changed, 94 bytes removed
> > 
> > net/ipv4/tcp_input.c:
> >   tcp_may_update_window |  +56
> >  1 function changed, 56 bytes added
> > 
> > net/ipv4/tcp_input.o:
> >  3 functions changed, 56 bytes added, 94 bytes removed, diff: -38
> > 
> > 
> > diff: xx is not always present.
> 
> Fixed, please do a git-pull.

...much better with piped sort now (only added lines seemed to show up 
still without diff and they're not that interesting after all :-)), but
I think this is needed as well to complete the change...

-- 
 i.

--
[PATCH] [CODIFF]: Be even more consistent on the summary lines

Forgotten change similar to the previous patch.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen-pxSi+dnQzZMxHbG02/KK1g@public.gmane.org>
---
 codiff.c |   17 +++++------------
 1 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/codiff.c b/codiff.c
index 0eada19..3e59e95 100644
--- a/codiff.c
+++ b/codiff.c
@@ -568,27 +568,20 @@ static int cu_show_diffs_iterator(struct cu *cu, void *cookie)
 
 static void print_total_function_diff(const char *filename)
 {
-	int kind = 0;
-
 	printf("\n%s:\n", filename);
 
 	printf(" %u function%s changed", total_nr_functions_changed,
 	       total_nr_functions_changed > 1 ? "s" : "");
 
-	if (total_function_bytes_added != 0) {
-		++kind;
+	if (total_function_bytes_added != 0)
 		printf(", %u bytes added", total_function_bytes_added);
-	}
 
-	if (total_function_bytes_removed != 0) {
-		++kind;
+	if (total_function_bytes_removed != 0)
 		printf(", %u bytes removed", total_function_bytes_removed);
-	}
   
-	if (kind == 2)
-		printf(", diff: %+d",
-		       (total_function_bytes_added -
-		        total_function_bytes_removed));
+	printf(", diff: %+d",
+	       (total_function_bytes_added -
+	        total_function_bytes_removed));
 	putchar('\n');
 }
 
-- 
1.5.0.6

  parent reply	other threads:[~2008-01-03 22:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.64.0801031528400.14949@kivilampi-30.cs.helsinki.fi>
     [not found] ` <Pine.LNX.4.64.0801031528400.14949-Y/UOj9v5BLQhZigby9b+C6cUovnZ0M2TMR2xtNvyitY@public.gmane.org>
2008-01-03 15:10   ` codiff misses changes if inline -> not inlined? Arnaldo Carvalho de Melo
     [not found]     ` <20080103151044.GD29523-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>
2008-01-03 16:45       ` Ilpo Järvinen
     [not found]         ` <Pine.LNX.4.64.0801031728330.14949-Y/UOj9v5BLQhZigby9b+C6cUovnZ0M2TMR2xtNvyitY@public.gmane.org>
2008-01-03 16:56           ` Arnaldo Carvalho de Melo
     [not found]             ` <20080103165605.GF29523-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>
2008-01-03 22:41               ` Ilpo Järvinen [this message]
     [not found]                 ` <Pine.LNX.4.64.0801040038510.20866-Y/UOj9v5BLQhZigby9b+C6cUovnZ0M2TMR2xtNvyitY@public.gmane.org>
2008-01-03 23:29                   ` Arnaldo Carvalho de Melo
2008-01-03 23:30                   ` Arnaldo Carvalho de Melo
     [not found] ` <20080103143139.GC29523@ghostprotocols.net>
     [not found]   ` <20080103143139.GC29523-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>
2008-01-03 23:24     ` Ilpo Järvinen
     [not found]       ` <Pine.LNX.4.64.0801040111530.16761-Y/UOj9v5BLQhZigby9b+C6cUovnZ0M2TMR2xtNvyitY@public.gmane.org>
2008-01-03 23:35         ` Arnaldo Carvalho de Melo
2008-01-04  0:27         ` Arnaldo Carvalho de Melo
     [not found]           ` <20080104002746.GR29523-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>
2008-01-04  1:39             ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0801040038510.20866@kivilampi-30.cs.helsinki.fi \
    --to=ilpo.jarvinen-pxsi+dnqzzmxhbg02/kk1g@public.gmane.org \
    --cc=acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=dwarves-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).