From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91C39C48BE6 for ; Thu, 17 Jun 2021 00:16:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EADB613BF for ; Thu, 17 Jun 2021 00:16:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234938AbhFQASO (ORCPT ); Wed, 16 Jun 2021 20:18:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:57470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234929AbhFQASO (ORCPT ); Wed, 16 Jun 2021 20:18:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6599D613BD; Thu, 17 Jun 2021 00:16:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623888967; bh=GYiYmhAjYaqpOXq8CVYNrtIQUSYlwsfAjPsR+AJY/W8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j8k5KpOvPRglb8virzZ36m3bbTOrEaTC2+pgQOzt7o655ai7p4pEG+ikTVhVEmK6Q OfmRBwLo+xPc9yLjdyfbL2zCp1wvYmu1IYgZ5vQ4WQ1hP3ygOWm+LW7fYSrDcmzhSl cj+vQ4uCl0cBHMyykAB6I7SpJ1MOZMOSLEnmkN6cf61k3KpRSDBSkOaOmvQce6TT3i pYBIF758OihlpGTyV5NNpchhcX0u+zz0vSej+55XtAlw9I9MkLcSgcc5pFzaH0Ruh3 TFQt5VRW1H3L2CY9yFWAkfr99sjHicOVjM1aPefU6gJOA+pbfBf+Gp3spKaVHVBA8b EdDFJaWjHec/g== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EC33240B1A; Wed, 16 Jun 2021 21:16:04 -0300 (-03) Date: Wed, 16 Jun 2021 21:16:04 -0300 From: Arnaldo Carvalho de Melo To: Andrii Nakryiko Cc: Arnaldo Carvalho de Melo , bpf , dwarves@vger.kernel.org, siudin@fb.com Subject: Re: latest pahole breaks libbpf CI and let's talk about staging Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: dwarves@vger.kernel.org Em Wed, Jun 16, 2021 at 03:38:38PM -0700, Andrii Nakryiko escreveu: > On Wed, Jun 16, 2021 at 11:25 AM Arnaldo Carvalho de Melo wrote: > > Em Wed, Jun 16, 2021 at 10:40:45AM -0700, Andrii Nakryiko escreveu: > > > On Wed, Jun 16, 2021 at 7:56 AM Arnaldo Carvalho de Melo wrote: > > > > Em Tue, Jun 15, 2021 at 04:30:03PM -0700, Andrii Nakryiko escreveu: > > > > > Hey Arnaldo, > > > > > Seems like de3a7f912559 ("btf_encoder: Reduce the size of encode_cu() > > > > > by moving function encoding to separate method") break two selftests > > > > > in libbpf CI (see [0]). Please take a look. I suspect some bad BTF, > > > > > because both tests rely on kernel BTF info. > > > > > You've previously asked about staging pahole changes. Did you make up > > > > > your mind about branch names and the process overall? Seems like a > > > > > good chance to bring this up ;-P > > > > > [0] https://travis-ci.com/github/libbpf/libbpf/jobs/514329152 > > > > Ok, please add tmp.master as the staging branch, I'll move things to > > > > master only after it passing thru CI. > > > > > > So I'm thinking about what's the best setup to catch pahole staging > > > problems, but not break main libbpf CI and kernel-patches CI flows. > > > How about we keep all the existing CI jobs to use pahole's master. > > Agreed. > > > Then add a separate job to do full kernel build with pahole built from > > > staging branch. And mark it as non-critical (or whatever the > > > terminology), so it doesn't mark the build red. I'd do that as a cron > > > job that runs every day. That way if you don't have anything urgent, > > > next day you'll get staging tested automatically. If you need to test > > > right now, there is a way to re-trigger previous build and it will > > > re-fetch latest staging (so there is a way for you to proactively > > > test). > > > Basically, I want broken staging pahole to not interrupt anything we > > > are doing. WDYT? > > Sounds like a plan, please hand hold me on this, I'm not versed on > > github. > I'll set up everything from my side, and then we'll just setup proper > access rights for you to be able to trigger builds. We are migrating > everything from Travis CI to Github Actions, and I'm not yet too > familiar with Github Actions, so I might need a few iterations. Ok dokey > BTW, while you are investigating pahole regression, can you please > revert the offending commit and push it to master to make out CIs > green again? Sure, just did it. Lets see if makes things green again. - Arnaldo