dwarves.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: dxu@dxuuu.xyz, dwarves@vger.kernel.org,
	andrii.nakryiko@gmail.com, jolsa@kernel.org, bpf@vger.kernel.org,
	eddyz87@gmail.com
Subject: Re: [PATCH dwarves 0/2] replace --btf_features="all" with "default"
Date: Tue, 23 Apr 2024 14:54:18 -0300	[thread overview]
Message-ID: <Zif1ysMXHRd01ovg@x1> (raw)
In-Reply-To: <20240423160200.3139270-1-alan.maguire@oracle.com>

On Tue, Apr 23, 2024 at 05:01:58PM +0100, Alan Maguire wrote:
> Use of "all" in --btf_features is confusing; use the "default" keyword
> to request default set of BTF features for encoding instead.  Then
> non-standard features can be added in a more natural way; i.e.
> 
> --btf_features=default,reproducible_build
> 
> Patch 1 makes this change in pahole.c and documentation.
> Patch 2 adjusts the reproducible build selftest to use "default"
> instead of "all".
> 
> This series is applicable on the "next" branch.

Applied to the next branch, I also refreshed the patches adding the
alternative + syntax, its basically a one liner :-)

I'll leave it there for a day for the libbpf CI to test with it and then
will move all to 'master'.

The first patch of Daniel's series got merged as well, it would be good
to refresh the other two patches on top of what we have in 'next' now,
Daniel?

Thanks!

- Arnaldo
 
> Alan Maguire (2):
>   pahole: replace use of "all" with "default" for --btf_features
>   tests: update reproducible_build test to use "default"
> 
>  man-pages/pahole.1          |  4 +-
>  pahole.c                    | 75 +++++++++++++++++++------------------
>  tests/reproducible_build.sh |  4 +-
>  3 files changed, 43 insertions(+), 40 deletions(-)
> 
> -- 
> 2.39.3

  parent reply	other threads:[~2024-04-23 17:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23 16:01 [PATCH dwarves 0/2] replace --btf_features="all" with "default" Alan Maguire
2024-04-23 16:01 ` [PATCH dwarves 1/2] pahole: replace use of "all" with "default" for --btf_features Alan Maguire
2024-04-23 16:02 ` [PATCH dwarves 2/2] tests: update reproducible_build test to use "default" Alan Maguire
2024-04-23 17:54 ` Arnaldo Carvalho de Melo [this message]
2024-04-24  3:32   ` [PATCH dwarves 0/2] replace --btf_features="all" with "default" Daniel Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zif1ysMXHRd01ovg@x1 \
    --to=acme@kernel.org \
    --cc=alan.maguire@oracle.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=dwarves@vger.kernel.org \
    --cc=dxu@dxuuu.xyz \
    --cc=eddyz87@gmail.com \
    --cc=jolsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).