From: Dave Jiang <dave.jiang@intel.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Fan Ni <fan.ni@samsung.com>,
"alison.schofield@intel.com" <alison.schofield@intel.com>,
"vishal.l.verma@intel.com" <vishal.l.verma@intel.com>,
"ira.weiny@intel.com" <ira.weiny@intel.com>,
"bwidawsk@kernel.org" <bwidawsk@kernel.org>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
Adam Manzanares <a.manzanares@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl/hdm: Fix hdm decoder init by adding COMMIT field check
Date: Thu, 2 Mar 2023 10:02:13 -0700 [thread overview]
Message-ID: <e17d59b0-ac81-8c7a-be0b-40eb419193c6@intel.com> (raw)
In-Reply-To: <20230302162838.euflpp5luvkqcc7f@offworld>
On 3/2/23 9:28 AM, Davidlohr Bueso wrote:
> On Thu, 02 Mar 2023, Dave Jiang wrote:
>
>> It does sound like a bug with QEMU emulation currently.
>
> Agreed, but still, crashing the kernel is always a no no - like with
> the passthrough decoder situation we had.
I wonder if we are missing a check in cxl_decoder_commit() to exit if
COMMITTED bit is set in register. The current code just blindly start
programming the registers.
>
> Thanks,
> Davidlohr
next prev parent reply other threads:[~2023-03-02 17:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230228224029uscas1p1e2fb92a8a595f80fa2985b452899d785@uscas1p1.samsung.com>
2023-02-28 22:40 ` [PATCH] cxl/hdm: Fix hdm decoder init by adding COMMIT field check Fan Ni
2023-03-01 18:54 ` Dave Jiang
2023-03-02 6:23 ` Fan Ni
2023-03-02 15:36 ` Dave Jiang
2023-03-02 16:28 ` Davidlohr Bueso
2023-03-02 17:02 ` Dave Jiang [this message]
2023-03-03 14:36 ` Jonathan Cameron
2023-03-03 15:57 ` Ira Weiny
2023-03-06 15:49 ` Jonathan Cameron
2023-03-03 17:21 ` Fan Ni
2023-03-06 16:04 ` Jonathan Cameron
2023-03-07 11:12 ` Jonathan Cameron
2023-03-07 17:27 ` Ira Weiny
2023-03-13 10:10 ` Jonathan Cameron
2023-03-13 16:50 ` Jonathan Cameron
2023-03-03 20:58 ` Dan Williams
2023-03-03 21:54 ` Fan Ni
2023-03-03 22:36 ` Dan Williams
2023-03-22 16:45 ` Fan Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e17d59b0-ac81-8c7a-be0b-40eb419193c6@intel.com \
--to=dave.jiang@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=a.manzanares@samsung.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=fan.ni@samsung.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.