From: Zi Yan <ziy@nvidia.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org, willy@infradead.org, hare@suse.de,
john.g.garry@oracle.com, p.raghav@samsung.com,
da.gomez@samsung.com
Subject: Re: [PATCH] mm/huge_memory: move writeback and truncation checks early
Date: Wed, 24 Apr 2024 21:07:16 -0400 [thread overview]
Message-ID: <0273A5B5-0BAB-4A11-A760-5337927B0264@nvidia.com> (raw)
In-Reply-To: <20240424225736.1501030-1-mcgrof@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2291 bytes --]
On 24 Apr 2024, at 18:57, Luis Chamberlain wrote:
> We should check as early as possible if we should bail due to writeback
> or truncation. This will allow us to add further sanity checks earlier
> as well.
>
> This introduces no functional changes.
>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
> mm/huge_memory.c | 23 +++++++++++------------
> 1 file changed, 11 insertions(+), 12 deletions(-)
>
> While working on min order support for LBS this came up as an improvement
> as we can check for the min order early earlier, so this sets the stage
> up for that.
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 86a8c7b3b8dc..32c701821e0d 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -3055,8 +3055,17 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list,
> if (new_order >= folio_order(folio))
> return -EINVAL;
>
> - /* Cannot split anonymous THP to order-1 */
> - if (new_order == 1 && folio_test_anon(folio)) {
> + if (folio_test_writeback(folio))
> + return -EBUSY;
> +
> + if (!folio_test_anon(folio)) {
> + /* Truncated ? */
> + if (!folio->mapping) {
> + ret = -EBUSY;
> + goto out;
> + }
> + } else if (new_order == 1) {
> + /* Cannot split anonymous THP to order-1 */
> VM_WARN_ONCE(1, "Cannot split to order-1 folio");
> return -EINVAL;
> }
> @@ -3079,16 +3088,12 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list,
> }
> }
>
> -
> is_hzp = is_huge_zero_page(&folio->page);
> if (is_hzp) {
> pr_warn_ratelimited("Called split_huge_page for huge zero page\n");
> return -EBUSY;
> }
>
> - if (folio_test_writeback(folio))
> - return -EBUSY;
> -
> if (folio_test_anon(folio)) {
> /*
> * The caller does not necessarily hold an mmap_lock that would
> @@ -3111,12 +3116,6 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list,
>
> mapping = folio->mapping;
>
> - /* Truncated ? */
> - if (!mapping) {
> - ret = -EBUSY;
> - goto out;
> - }
> -
> /*
> * Do not split if mapping has minimum folio order
> * requirement.
> --
> 2.43.0
LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>
--
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2024-04-25 1:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 22:57 [PATCH] mm/huge_memory: move writeback and truncation checks early Luis Chamberlain
2024-04-25 1:07 ` Zi Yan [this message]
2024-04-25 9:40 ` David Hildenbrand
2024-05-01 22:06 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0273A5B5-0BAB-4A11-A760-5337927B0264@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=da.gomez@samsung.com \
--cc=fstests@vger.kernel.org \
--cc=hare@suse.de \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).