From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: <fdmanana@gmail.com>
Cc: <darrick.wong@oracle.com>, <fstests@vger.kernel.org>,
Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Subject: [PATCH v2] generic/520: Remove sync in clean_dir
Date: Mon, 23 Dec 2019 18:21:39 +0800 [thread overview]
Message-ID: <1577096499-23471-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> (raw)
When I test this case on xfs, it may fail as below:
--------------------------------------------
=== link SCRATCH_MNT/A/foo SCRATCH_MNT/bar with fsync SCRATCH_MNT/A ===
+umount: /mnt/xfstests/scratch: target is busy.
+ (In some cases useful info about processes that use
+ the device is found by lsof(8) or fuser(1))
---------------------------------------------
It fails because somethings is still using the fs when we call sync and then
try to unmount it. We can simply remove sync as the unmount is supposed to
persist the file/directory removals.
Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
tests/generic/520 | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/generic/520 b/tests/generic/520
index 167d7077..d4457370 100755
--- a/tests/generic/520
+++ b/tests/generic/520
@@ -58,7 +58,6 @@ clean_dir()
{
_mount_flakey
rm -rf $(find $SCRATCH_MNT/* | grep -v "lost+found")
- sync
_unmount_flakey
}
--
2.18.0
next reply other threads:[~2019-12-23 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 10:21 Yang Xu [this message]
2020-01-16 9:28 ` [PATCH v2] generic/520: Remove sync in clean_dir Yang Xu
2020-01-16 15:35 ` Darrick J. Wong
2020-01-17 2:57 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1577096499-23471-1-git-send-email-xuyang2018.jy@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=darrick.wong@oracle.com \
--cc=fdmanana@gmail.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).