From: Nikolay Borisov <nborisov@suse.com>
To: fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org, Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH 1/2] common/rc: Remove special handing of 'dup' argument for btrfs
Date: Fri, 27 Sep 2019 13:52:32 +0300 [thread overview]
Message-ID: <20190927105233.14926-1-nborisov@suse.com> (raw)
_scratch_pool_mkfs special cases the command executed when 'dup' option
is used when creating a filesystem. This is wrong since 'dup' works
for all profiles and number of devices. This bug manifested while
exercising btrfs' balance argument combinations test.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
common/rc | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/common/rc b/common/rc
index 9f2c252e5aa5..1b150cbad2f6 100644
--- a/common/rc
+++ b/common/rc
@@ -885,13 +885,7 @@ _scratch_pool_mkfs()
{
case $FSTYP in
btrfs)
- # if dup profile is in mkfs options call _scratch_mkfs instead
- # because dup profile only works with single device
- if [[ "$*" =~ dup ]]; then
- _scratch_mkfs $*
- else
- $MKFS_BTRFS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV_POOL > /dev/null
- fi
+ $MKFS_BTRFS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV_POOL > /dev/null
;;
*)
echo "_scratch_pool_mkfs is not implemented for $FSTYP" 1>&2
--
2.7.4
next reply other threads:[~2019-09-27 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 10:52 Nikolay Borisov [this message]
2019-09-27 10:52 ` [PATCH 2/2] btrfs: Add test for btrfs balance convert functionality Nikolay Borisov
2019-09-27 11:21 ` Qu Wenruo
2019-09-27 11:50 ` Nikolay Borisov
2019-09-27 12:22 ` Qu Wenruo
2019-09-27 13:18 ` Nikolay Borisov
2019-09-27 13:10 ` [PATCH 1/2] common/rc: Remove special handing of 'dup' argument for btrfs David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927105233.14926-1-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).