From: Qu Wenruo <wqu@suse.com>
To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: [PATCH] fstests: btrfs/153: Remove it from auto group
Date: Tue, 14 Jan 2020 20:50:44 +0800 [thread overview]
Message-ID: <20200114125044.21594-1-wqu@suse.com> (raw)
This test case always fail after commit c6887cd11149 ("Btrfs: don't do
nocow check unless we have to").
As btrfs no longer checks nodatacow at buffered write time.
That commits brings in a big performance enhancement, as that check is
not cheap, but breaks qgroup, as write into preallocated space now needs
extra space.
There isn't yet a good solution (reverting that patch is not possible,
and only check nodatacow for quota enabled case is very bug prune due to
quite a lot code change).
We may solve it using the new ticketed space reservation facility, but
that won't come into fruit anytime soon.
So let's just remove that test case from 'auto' group, but still keep
the test case to inform we still have a lot of work to do.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
tests/btrfs/group | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/btrfs/group b/tests/btrfs/group
index 697b6a38ea00..3c554a194742 100644
--- a/tests/btrfs/group
+++ b/tests/btrfs/group
@@ -155,7 +155,7 @@
150 auto quick dangerous
151 auto quick volume
152 auto quick metadata qgroup send
-153 auto quick qgroup limit
+153 quick qgroup limit
154 auto quick volume
155 auto quick send
156 auto quick trim
--
2.24.1
next reply other threads:[~2020-01-14 12:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 12:50 Qu Wenruo [this message]
2020-02-01 7:36 ` [PATCH] fstests: btrfs/153: Remove it from auto group Eryu Guan
2020-02-01 11:10 ` Amir Goldstein
2020-02-01 12:38 ` Qu Wenruo
2020-02-01 13:07 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114125044.21594-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).