From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 4/7] xfs/279: skip test if we can't allocate scsi_debug device
Date: Thu, 16 Jan 2020 01:24:41 -0800 [thread overview]
Message-ID: <20200116092441.GD21601@infradead.org> (raw)
In-Reply-To: <157915146054.2374854.14308605711454193767.stgit@magnolia>
On Wed, Jan 15, 2020 at 09:11:00PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Due to the unique structure of xfs/279 running _get_scsi_debug_dev from
> a backtick from inside subshell, the "could not get scsi_debug device"
> checks do not actually stop the test when modprobe scsi_debug fails.
>
> Therefore, check the value of SCSI_DEBUG_DEV from the subshell and
> _notrun the test if we couldn't get memory.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-01-16 9:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 5:10 [PATCH 0/7] fstests: random fixes Darrick J. Wong
2020-01-16 5:10 ` [PATCH 1/7] xfs/449: filter out "Discarding..." from output Darrick J. Wong
2020-01-16 9:23 ` Christoph Hellwig
2020-01-16 5:10 ` [PATCH 2/7] xfs/122: add disk dquot structure to the list Darrick J. Wong
2020-01-16 9:23 ` Christoph Hellwig
2020-01-16 5:10 ` [PATCH 3/7] xfs/507: skip if we can't create a large sparse file for testing Darrick J. Wong
2020-01-16 9:24 ` Christoph Hellwig
2020-01-16 5:11 ` [PATCH 4/7] xfs/279: skip test if we can't allocate scsi_debug device Darrick J. Wong
2020-01-16 9:24 ` Christoph Hellwig [this message]
2020-01-16 5:11 ` [PATCH 5/7] rc: fix _get_max_lfs_filesize on 32-bit platforms Darrick J. Wong
2020-01-16 9:25 ` Christoph Hellwig
2020-01-16 5:11 ` [PATCH 6/7] generic/108: skip test if we can't initialize scsi_debug Darrick J. Wong
2020-01-16 9:25 ` Christoph Hellwig
2020-01-16 5:11 ` [PATCH 7/7] xfs/020: call _notrun if we can't create a 60t sparse image Darrick J. Wong
2020-01-16 9:25 ` Christoph Hellwig
2020-02-02 19:54 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116092441.GD21601@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).