fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Murphy Zhou <jencce.kernel@gmail.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
	Christoph Hellwig <hch@infradead.org>,
	fstests@vger.kernel.org
Subject: Re: [PATCH] generic: require fibmap for testcases using filefrag
Date: Sun, 19 Jan 2020 14:02:52 -0800	[thread overview]
Message-ID: <20200119220252.GA9313@infradead.org> (raw)
In-Reply-To: <20200118093851.s3qynwkyi4ay2vqc@xzhoux.usersys.redhat.com>

On Sat, Jan 18, 2020 at 05:38:51PM +0800, Murphy Zhou wrote:
> > But do those tests require filefrag -B??
> 
> Not really. But filefrag will fall back to use fibmap.

But that means it requires either FIEMAP or FIBMAP, and your patch
will cause regressions for file systems only implementing FIEMAP.
So the fix isn't to ask for FIBMAP, but to implement FIEMAP in
any file system missing that support.

  reply	other threads:[~2020-01-19 22:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-17  8:38 [PATCH] generic: require fibmap for testcases using filefrag Murphy Zhou
2020-01-17  8:45 ` Christoph Hellwig
2020-01-17 10:02   ` Murphy Zhou
2020-01-18  0:47     ` Darrick J. Wong
2020-01-18  9:38       ` Murphy Zhou
2020-01-19 22:02         ` Christoph Hellwig [this message]
2020-01-22 10:22           ` Murphy Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200119220252.GA9313@infradead.org \
    --to=hch@infradead.org \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=jencce.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).