fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu@gmail.com>
To: Josef Bacik <josef@toxicpanda.com>
Cc: kernel-team@fb.com, fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] fstests: add perf to the list of test directories
Date: Sun, 23 Feb 2020 20:56:49 +0800	[thread overview]
Message-ID: <20200223125135.GC3840@desktop> (raw)
In-Reply-To: <20200218142945.3719579-1-josef@toxicpanda.com>

On Tue, Feb 18, 2020 at 09:29:45AM -0500, Josef Bacik wrote:
> I noticed that despite having PERF_CONFIGNAME set I wasn't getting the
> perf/ tests run when I used -g auto.  This is because it's not included
> in the list of directories to look at.  Fix this so that perf tests get
> run as well.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>

I don't think the perf test infra is widely used by developers and
testers yet, so adding perf tests to default 'auto' tests would bring
unexpected failures.

So I think it's better to keep it not run by default for now, and if you
want to run perf tests in your test env, you could do it easily by
adding "-g perf/auto" option to "./check", e.g.

	./check -g auto -g perf/auto

And if there're frequent users of the perf infra, please reply this
thread and let us know, it'd be interesting to know how many users are
there.

Thanks,
Eryu

> ---
>  check | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/check b/check
> index 89f3358a..9e7b6134 100755
> --- a/check
> +++ b/check
> @@ -44,7 +44,7 @@ timestamp=${TIMESTAMP:=false}
>  
>  rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.*
>  
> -SRC_GROUPS="generic shared"
> +SRC_GROUPS="generic shared perf"
>  export SRC_DIR="tests"
>  
>  usage()
> -- 
> 2.24.1
> 

      parent reply	other threads:[~2020-02-23 12:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18 14:29 [PATCH] fstests: add perf to the list of test directories Josef Bacik
2020-02-19 11:52 ` Zorro Lang
2020-02-23 12:56 ` Eryu Guan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200223125135.GC3840@desktop \
    --to=guaneryu@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).