fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yong Sun <sunyong0511@gmail.com>
To: fstests@vger.kernel.org
Cc: Yong Sun <yosun@suse.com>, sandeen@sandeen.net, pvorel@suse.cz
Subject: [PATCH v3] fstests: modify user name beginning with non-digit
Date: Fri,  5 Jun 2020 11:12:38 +0800	[thread overview]
Message-ID: <20200605031236.7529-1-yosun@suse.com> (raw)

openSUSE and SLE don't support username begin with digit, so it will
skip test generic/597 and generic/598 by lack of 123456-fsgqa user.
generic/597 and 598 are not test username begin with digit on purpose
(different with generic/381). It's will be helpful to use an username
begin with non-digit in this case.

Signed-off-by: Sun Yong <yosun@suse.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
---
v2: Remove invalid comments after change
v3: Add relevant comment back and choose a better username
---
 README            | 1 +
 tests/generic/597 | 6 ++----
 tests/generic/598 | 6 ++----
 3 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/README b/README
index 094a7742..f1fac399 100644
--- a/README
+++ b/README
@@ -22,6 +22,7 @@ _______________________
 - create fsgqa test user ("sudo useradd -m fsgqa")
 - create fsgqa group ("sudo groupadd fsgqa")
 - create 123456-fsgqa test user ("sudo useradd 123456-fsgqa")
+- create fsgqa2 test user ("sudo useradd fsgqa2")
 
 ______________________
 USING THE FSQA SUITE
diff --git a/tests/generic/597 b/tests/generic/597
index 1d87a23a..df6911a1 100755
--- a/tests/generic/597
+++ b/tests/generic/597
@@ -41,13 +41,11 @@ _supported_os Linux
 _require_test
 _require_sysctl_variable fs.protected_symlinks
 _require_sysctl_variable fs.protected_hardlinks
-# su in _require_user prints warnings about user name starts with a digit,
-# discard the warning
-_require_user 123456-fsgqa >/dev/null 2>&1
+_require_user fsgqa2
 # Do this SECOND so that qa_user is fsgqa, and _user_do uses that account
 _require_user fsgqa
 
-OWNER=123456-fsgqa
+OWNER=fsgqa2
 OTHER=fsgqa
 
 # Save current system state to reset when done
diff --git a/tests/generic/598 b/tests/generic/598
index 998b62cf..119d5644 100755
--- a/tests/generic/598
+++ b/tests/generic/598
@@ -41,13 +41,11 @@ _supported_os Linux
 _require_test
 _require_sysctl_variable fs.protected_regular
 _require_sysctl_variable fs.protected_fifos
-# su in _require_user prints warnings about user name starts with a digit,
-# discard the warning
-_require_user 123456-fsgqa >/dev/null 2>&1
+_require_user fsgqa2
 # Do this SECOND so that qa_user is fsgqa, and _user_do uses that account
 _require_user fsgqa
 
-USER1=123456-fsgqa
+USER1=fsgqa2
 USER2=fsgqa
 
 # Save current system state to reset when done
-- 
2.26.2


             reply	other threads:[~2020-06-05  3:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05  3:12 Yong Sun [this message]
2020-06-05  6:40 ` [PATCH v3] fstests: modify user name beginning with non-digit Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200605031236.7529-1-yosun@suse.com \
    --to=sunyong0511@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=pvorel@suse.cz \
    --cc=sandeen@sandeen.net \
    --cc=yosun@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).