From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/096: filter out the "Discarding..." output
Date: Tue, 9 Jun 2020 09:10:39 -0700 [thread overview]
Message-ID: <20200609161039.GA11242@magnolia> (raw)
In-Reply-To: <20200609082442.31982-1-zlang@redhat.com>
On Tue, Jun 09, 2020 at 04:24:42PM +0800, Zorro Lang wrote:
> Latest xfsprogs mkfs.xfs prints "Discarding blocks...Done" if the
> disk supports the trim. That breaks the golden image, cause
> unexpected failure, so filter out it.
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
Seems reasonable to me...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> tests/xfs/096 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/xfs/096 b/tests/xfs/096
> index ef6136af..04bc7b7d 100755
> --- a/tests/xfs/096
> +++ b/tests/xfs/096
> @@ -78,6 +78,7 @@ mkfs_filter()
> -e 's/ ftype=[01]//' \
> -e '/^log stripe unit.*too large/d' \
> -e '/^log stripe unit adjusted/d' \
> + -e '/Discarding/d' \
> | grep -v parent
> }
>
> --
> 2.20.1
>
prev parent reply other threads:[~2020-06-09 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 8:24 [PATCH] xfs/096: filter out the "Discarding..." output Zorro Lang
2020-06-09 16:10 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609161039.GA11242@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).