From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Vladimir Zapolskiy <vladimir@tuxera.com>
Cc: Eryu Guan <guaneryu@gmail.com>, fstests@vger.kernel.org
Subject: Re: [PATCH] generic: assign a number of tests to attr group
Date: Mon, 13 Jul 2020 09:45:54 -0700 [thread overview]
Message-ID: <20200713164554.GI7600@magnolia> (raw)
In-Reply-To: <20200713122628.16781-1-vladimir@tuxera.com>
On Mon, Jul 13, 2020 at 03:26:28PM +0300, Vladimir Zapolskiy wrote:
> A few generic tests have a _require_attrs runtime check for support
> of extended file attributes by a tested filesystem, review shows that
> the tests listed below are definitely using extended file attributes,
> thus this implies that the tested filesystem should provide support of
> the feature in general.
>
> Adding the tests explicitly to attr group of tests allows to get a better
> granularity of selecting or deselecting tests by groups in accordance to
> extended file attributes feature given by a filesystem, the change affects
> the next list of tests:
>
> * generic/037
> * generic/066
> * generic/103
> * generic/337
> * generic/449
Aha! I had long suspected the attr group was missing a few tests...
> Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> tests/generic/group | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/generic/group b/tests/generic/group
> index 3d7effe6d72a..a09c81a09abc 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -39,7 +39,7 @@
> 034 auto quick metadata log
> 035 auto quick
> 036 auto aio rw stress
> -037 metadata auto quick
> +037 auto quick attr metadata
> 038 auto stress
> 039 metadata auto quick log
> 040 metadata auto quick log
> @@ -68,7 +68,7 @@
> 063 auto quick prealloc punch insert
> 064 auto quick prealloc collapse insert
> 065 metadata auto quick log
> -066 metadata auto quick log
> +066 auto quick attr metadata log
> 067 auto quick mount
> 068 other auto freeze stress
> 069 rw udf auto quick
> @@ -105,7 +105,7 @@
> 100 udf auto
> 101 auto quick metadata log
> 102 auto rw
> -103 auto enospc quick
> +103 auto quick attr enospc
> 104 auto quick metadata log
> 105 acl auto quick
> 106 auto quick metadata log
> @@ -339,7 +339,7 @@
> 334 auto clone
> 335 auto quick metadata log
> 336 auto quick metadata log
> -337 auto quick metadata
> +337 auto quick attr metadata
> 338 auto quick rw eio
> 339 auto dir
> 340 auto
> @@ -451,7 +451,7 @@
> 446 auto quick rw punch
> 447 auto clone
> 448 auto quick rw seek
> -449 auto quick acl enospc
> +449 auto quick acl attr enospc
> 450 auto quick rw
> 451 auto quick rw aio
> 452 auto quick dax
> --
> 2.25.1
>
prev parent reply other threads:[~2020-07-13 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 12:26 [PATCH] generic: assign a number of tests to attr group Vladimir Zapolskiy
2020-07-13 16:45 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713164554.GI7600@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=vladimir@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).