From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] Fix generic/127 to exit if any subtest fails
Date: Mon, 19 Oct 2020 09:04:08 -0700 [thread overview]
Message-ID: <20201019160408.GD9830@magnolia> (raw)
In-Reply-To: <20201019125839.GQ20115@casper.infradead.org>
On Mon, Oct 19, 2020 at 01:58:39PM +0100, Matthew Wilcox wrote:
>
> If one of the subtests of generic/127 fails, we proceed with the rest of
> the tests, potentially overwriting useful data. This makes it stop as
> soon as any of the subtests fails.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Yayyyyyyy
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
>
> diff --git a/tests/generic/127 b/tests/generic/127
> index dedd8bbf..d4b2cc38 100755
> --- a/tests/generic/127
> +++ b/tests/generic/127
> @@ -90,16 +90,16 @@ _supported_fs generic
> _supported_os Linux
> _require_test
>
> -_fsx_lite_nommap
> -_fsx_lite_mmap
> +_fsx_lite_nommap || exit
> +_fsx_lite_mmap || exit
>
> -_fsx_std_nommap
> -_fsx_std_mmap
> +_fsx_std_nommap || exit
> +_fsx_std_mmap || exit
>
> #flush cache after write
> FSX_ARGS="-f $FSX_ARGS"
> -_fsx_std_nommap
> -_fsx_std_mmap
> +_fsx_std_nommap || exit
> +_fsx_std_mmap || exit
>
> status=0
> _cleanup
>
prev parent reply other threads:[~2020-10-19 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 12:58 [PATCH] Fix generic/127 to exit if any subtest fails Matthew Wilcox
2020-10-19 16:04 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019160408.GD9830@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).