From: "Darrick J. Wong" <djwong@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Eryu Guan <guaneryu@gmail.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
fstests <fstests@vger.kernel.org>, Eryu Guan <guan@eryu.me>
Subject: Re: [PATCH 1/1] xfs: test that the needsrepair feature works as advertised
Date: Wed, 21 Apr 2021 08:58:43 -0700 [thread overview]
Message-ID: <20210421155843.GC3122235@magnolia> (raw)
In-Reply-To: <CAOQ4uxhvt0j7r6ZSTiwX8T7uPw5eVH+uMegt+ActLeopmpJy7Q@mail.gmail.com>
On Wed, Apr 21, 2021 at 09:01:05AM +0300, Amir Goldstein wrote:
> On Wed, Apr 21, 2021 at 3:23 AM Darrick J. Wong <djwong@kernel.org> wrote:
> >
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Make sure that the needsrepair feature flag can be cleared only by
> > repair and that mounts are prohibited when the feature is set.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> > common/xfs | 28 ++++++++++++++++++
> > tests/xfs/768 | 80 +++++++++++++++++++++++++++++++++++++++++++++++++++
> > tests/xfs/768.out | 4 +++
> > tests/xfs/770 | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> > tests/xfs/770.out | 2 +
> > tests/xfs/group | 2 +
> > 6 files changed, 199 insertions(+)
> > create mode 100755 tests/xfs/768
> > create mode 100644 tests/xfs/768.out
> > create mode 100755 tests/xfs/770
> > create mode 100644 tests/xfs/770.out
> >
> >
> > diff --git a/common/xfs b/common/xfs
> > index 887bd001..c2384146 100644
> > --- a/common/xfs
> > +++ b/common/xfs
> > @@ -312,6 +312,13 @@ _scratch_xfs_check()
> > _xfs_check $SCRATCH_OPTIONS $* $SCRATCH_DEV
> > }
> >
> > +_require_libxfs_debug_flag() {
> > + local hook="$1"
> > +
> > + grep -q LIBXFS_DEBUG_WRITE_CRASH "$(type -P xfs_repair)" || \
> > + _notrun "libxfs debug hook $hook not detected?"
>
> You ignored the $hook arg.
> And this is a bit of a strange test.
Doh. Will fix; thanks for noticing that. :)
> In _require_unionmount_testsuite() I also pass env vars to the test utility
> and I made it so the usage message will print the non empty env vars
> passed to the programm.
>
> I can understand if nothing like that was done for xfs_repair and you want
> this test to work with an already released version of xfs_repair, but if that
> test is against a pre-released version of xfs_repair, I suggest to make it
> more friendly for _require check.
That would have been a good idea, but we already shipped this in 5.11.
:/
--D
> Thanks,
> Amir.
next prev parent reply other threads:[~2021-04-21 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 0:22 [PATCHSET v5 0/1] fstests: make sure NEEDSREPAIR feature stops mounts Darrick J. Wong
2021-04-21 0:22 ` [PATCH 1/1] xfs: test that the needsrepair feature works as advertised Darrick J. Wong
2021-04-21 6:01 ` Amir Goldstein
2021-04-21 15:58 ` Darrick J. Wong [this message]
2021-04-21 17:29 ` Brian Foster
2021-04-21 20:37 ` Darrick J. Wong
2021-04-22 11:25 ` Brian Foster
2021-04-22 0:49 ` [PATCH v5.1 " Darrick J. Wong
2021-04-22 11:26 ` Brian Foster
-- strict thread matches above, loose matches on Subject: below --
2021-04-14 1:05 [PATCHSET v4 0/1] fstests: make sure NEEDSREPAIR feature stops mounts Darrick J. Wong
2021-04-14 1:05 ` [PATCH 1/1] xfs: test that the needsrepair feature works as advertised Darrick J. Wong
2021-04-18 12:14 ` Eryu Guan
2021-04-20 18:26 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421155843.GC3122235@magnolia \
--to=djwong@kernel.org \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).