From: "Darrick J. Wong" <djwong@kernel.org>
To: Luis Henriques <lhenriques@suse.de>
Cc: fstests@vger.kernel.org, Eryu Guan <guan@eryu.me>,
Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH 2/2] generic/079: make sure users 'nobody' and 'daemon' exist
Date: Thu, 23 Sep 2021 12:48:05 -0700 [thread overview]
Message-ID: <20210923194805.GB570597@magnolia> (raw)
In-Reply-To: <20210923104123.29878-3-lhenriques@suse.de>
On Thu, Sep 23, 2021 at 11:41:23AM +0100, Luis Henriques wrote:
> Test 'src/t_immutable' assumes the existence of users 'nobody' and
> 'daemon' on the system. If any of these users don't exist, the test will
> fail with:
>
> add_acl(/media/scratch/079/immutable.f) did not set errno == EPERM
> ...
>
> because it tries to set ACLs such as:
>
> u::rwx,g::rwx,o::rwx,u:daemon:rwx,m::rwx
>
> Use the new _require_user_exists() function to ensure these users exist.
>
> Signed-off-by: Luis Henriques <lhenriques@suse.de>
Looks correct.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> tests/generic/079 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/generic/079 b/tests/generic/079
> index 829275db8cdf..9e7ccd31c8e2 100755
> --- a/tests/generic/079
> +++ b/tests/generic/079
> @@ -26,6 +26,8 @@ _cleanup()
> _supported_fs generic
>
> _require_chattr ia
> +_require_user_exists "nobody"
> +_require_user_exists "daemon"
> _require_test_program "t_immutable"
> _require_scratch
>
prev parent reply other threads:[~2021-09-23 19:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 10:41 [PATCH 0/2] generic/079 test fails if 'nobody' and 'daemon' don't exist Luis Henriques
2021-09-23 10:41 ` [PATCH 1/2] common/rc: add _require_user_exists() to check if a user exists Luis Henriques
2021-09-23 19:47 ` Darrick J. Wong
2021-09-23 19:53 ` Eric Biggers
2021-09-23 10:41 ` [PATCH 2/2] generic/079: make sure users 'nobody' and 'daemon' exist Luis Henriques
2021-09-23 19:48 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923194805.GB570597@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=lhenriques@suse.de \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).