From: Pavel Reichl <preichl@redhat.com>
To: Eryu Guan <guan@eryu.me>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v3 1/4] common/rc: Add _require_{chown,chmod}()
Date: Tue, 20 Apr 2021 00:06:47 +0200 [thread overview]
Message-ID: <882c5aad-4e0c-ba20-6007-dabdbf1ced11@redhat.com> (raw)
In-Reply-To: <YHwq/hmeTmGktR/G@desktop>
On 4/18/21 2:50 PM, Eryu Guan wrote:
> On Thu, Apr 15, 2021 at 11:49:02AM +0200, Pavel Reichl wrote:
...
>> +#
>> +_require_chmod()
>> +{
>> + _require_chown
>
> It's not clear to me why _require_chown also works for _require_chmod,
> other than actually doing chmod test. Some comments would be good.
Yeah, sorry about that. I just sent v4 of this patch that attempts to implement _require_chmod() properly.
>
> Thanks,
> Eryu
>
> P.S. I've applied other patches in this patchset, thanks for the fixes!
Awesome, thanks for the reviews.
>
next prev parent reply other threads:[~2021-04-19 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 9:49 [PATCH v3 0/4] Fix some tests that fail for exfat FS Pavel Reichl
2021-04-15 9:49 ` [PATCH v3 1/4] common/rc: Add _require_{chown,chmod}() Pavel Reichl
2021-04-18 12:50 ` Eryu Guan
2021-04-19 22:06 ` Pavel Reichl [this message]
2021-04-15 9:49 ` [PATCH v3 2/4] common: hide permision warning from mkswap for exfat Pavel Reichl
2021-04-15 9:49 ` [PATCH v3 3/4] generic/554: hide permision warning on exfat Pavel Reichl
2021-04-15 9:49 ` [PATCH v3 4/4] generic/003: Amend the test for exfat Pavel Reichl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=882c5aad-4e0c-ba20-6007-dabdbf1ced11@redhat.com \
--to=preichl@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).